Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement calculated size of clipped corners of OnyxImage #2894

Open
14 tasks
larsrickert opened this issue Mar 5, 2025 · 0 comments
Open
14 tasks

Implement calculated size of clipped corners of OnyxImage #2894

larsrickert opened this issue Mar 5, 2025 · 0 comments
Assignees
Labels
0-refinement All issues that can or need to be estimated in our next refinement dev Requires technical expertise

Comments

@larsrickert
Copy link
Collaborator

larsrickert commented Mar 5, 2025

Why?

Currently the clipped corners of the OnyxImage have a static size.

To align with the design requirements, they should be dynamic depending on the image height/width.

Acceptance criteria

  • the clipped corner size is changed to be 15% of the smaller side of the image (width or height, whatever is smaller)

Implementation details

  • we can use the current static clipped corner size as default and after mount, get the actual size with a resize observer and calculate the correct value

Definition of Done

  • The following component requirements are implemented:

    • skeleton
    • density
    • example usage added to apps/demo-app/src/views/HomeView.vue
  • Should be covered by tests:

    • functional tests (Playwright or unit test)
    • visual tests (Playwright screenshots)
  • Make sure, that

    • follow-up tickets were created if necessary
    • updated version + documentation is deployed
    • Storybook can show the feature
    • Storybook code snippet of new/changed examples are checked that they are generated correctly
    • Namings are aligned with Figma
    • Storybook sidebar badge for "New" is added on component or story level if needed. See: https://github.com/Sidnioulz/storybook-addon-tag-badges/?tab=readme-ov-file

Approval

Storybook

  • Checked and approved by
    • designer
    • dev
@larsrickert larsrickert added 0-refinement All issues that can or need to be estimated in our next refinement dev Requires technical expertise labels Mar 5, 2025
@larsrickert larsrickert self-assigned this Mar 5, 2025
@larsrickert larsrickert added this to onyx Mar 5, 2025
@github-project-automation github-project-automation bot moved this to New in onyx Mar 5, 2025
@larsrickert larsrickert changed the title Implement|Fix|Define calculated size of clipped corners of OnyxImage Implement calculated size of clipped corners of OnyxImage Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-refinement All issues that can or need to be estimated in our next refinement dev Requires technical expertise
Projects
Status: New
Development

No branches or pull requests

1 participant