Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions #2

Open
davidrpugh opened this issue Jun 18, 2017 · 4 comments
Open

Permissions #2

davidrpugh opened this issue Jun 18, 2017 · 4 comments

Comments

@davidrpugh
Copy link

@ibillett

I have re-instated write permissions for this repo (and docker-base) to the docker team. You are the maintainer for this team (which I thought should give you write permission but apparently not). I can not seem to work out how to give only one person on a team write permissions to the repos controlled by that team.

@ghost
Copy link

ghost commented Jun 18, 2017

Based on what you have done, I now have the ability to create new branches in the repo, but not commit directly to master because it is 'protected'.

Must be the case that only the creator can commit / merge PRs into master?

I'll do my best to keep the PRs short and sweet 😎

@davidrpugh
Copy link
Author

@ibillett protecting the master branch is a "best practice" it prevents, among other things, collaborators accidentally deleting the branch. Create a new feature branch with your changes and push the branch to this repo and then submit a PR.

@davidrpugh
Copy link
Author

@ibillett Has your permissions issue been sorted? Let me know. We seemed to have lost momentum and I would like get it back :)

@ghost
Copy link

ghost commented Jul 4, 2017

@davidrpugh Yes I think so, managed to push changes to the example-auctions branch. I need to sit down and figure out security permissions before submitting a PR.

Apologies for the lack of comms, it has been a crazy busy couple of weeks at work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant