Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constellation: Use ffmpeg to update thumbnails for video files #429

Open
lgmarchi opened this issue Jan 16, 2024 · 0 comments
Open

constellation: Use ffmpeg to update thumbnails for video files #429

lgmarchi opened this issue Jan 16, 2024 · 0 comments
Labels
enhancement New feature or request P-Low Low Priority

Comments

@lgmarchi
Copy link
Collaborator

lgmarchi commented Jan 16, 2024

1. Use ffmpeg to update thumbnails for video files

You would add it in https://github.com/Satellite-im/Warp/blob/main/extensions/warp-ipfs/src/thumbnail.rs. A couple of things to note though is that you might want to make sure the target isnt a mobile platform and you should be able to execute the command using tokio process command vs std (since internally it would spawn the blocking thread)
and it might be worth putting ffmpeg behind a feature gate too

@dariusc93 dariusc93 changed the title (Constellation): Add ffmpeg to update thumbnails for video files as well constellation: Add ffmpeg to update thumbnails for video files as well Jan 16, 2024
@dariusc93 dariusc93 added enhancement New feature or request P-Normal Normal Priority labels Jan 23, 2024
@dariusc93 dariusc93 changed the title constellation: Add ffmpeg to update thumbnails for video files as well constellation: Use ffmpeg to update thumbnails for video files Jan 25, 2024
@dariusc93 dariusc93 added P-Low Low Priority and removed P-Normal Normal Priority labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P-Low Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants