Fourth times the charm

Darkest-Teddy · Darkest-Teddy · commit d450c2582d20 · 2026-04-14T22:29:43.000-04:00
diff --git a/backend/routes/auth.py b/backend/routes/auth.py
@@ -67,6 +67,12 @@ def _decode_state(state: str) -> dict:
         return {}
 
 
+def _email_log_value(email: str) -> str:
+    if "@" in email:
+        return email.split("@")[-1]
+    return "unknown"
+
+
 @router.get("/google")
 def google_login():
     """Redirect to Google consent screen with identity + calendar scopes."""
@@ -105,16 +111,17 @@ def google_callback(code: str = Query(...), state: str = Query(None)):
         # Fetch user info from Google
         service = build("oauth2", "v2", credentials=creds)
         user_info = service.userinfo().get().execute()
-        print(f"[auth] step 3: user_info email={user_info.get('email')}")
 
         email = user_info.get("email", "")
+        email_log_value = _email_log_value(email)
+        print(f"[auth] step 3: user_info email_domain={email_log_value}")
         google_id = user_info.get("id", "")
         name = user_info.get("name", "")
         avatar_url = user_info.get("picture", "")
 
         # Restrict to .edu accounts
         if not email.endswith(".edu"):
-            print(f"[auth] rejected: not .edu ({email})")
+            print(f"[auth] rejected: not .edu (email_domain={email_log_value})")
             return RedirectResponse(f"{FRONTEND_URL}/?error=invalid_domain")
 
         is_new_user = False
diff --git a/backend/routes/calendar.py b/backend/routes/calendar.py
@@ -6,6 +6,7 @@
 """
 
 import json
+import logging
 from datetime import datetime, timezone, timedelta
 
 from fastapi import APIRouter, File, Form, HTTPException, Query, UploadFile
@@ -29,6 +30,7 @@
     GOOGLE_AVAILABLE = False
 
 router = APIRouter()
+logger = logging.getLogger(__name__)
 
 
 # ── Helpers ───────────────────────────────────────────────────────────────────
@@ -114,8 +116,8 @@ def save_assignments(body: SaveAssignmentsBody):
 
 @router.get("/upcoming/{user_id}")
 def get_upcoming(user_id: str):
+    today = datetime.utcnow().strftime("%Y-%m-%d")
     try:
-        today = datetime.utcnow().strftime("%Y-%m-%d")
         rows = table("assignments").select(
             "*",
             filters={"user_id": f"eq.{user_id}", "due_date": f"gte.{today}"},
@@ -124,6 +126,11 @@ def get_upcoming(user_id: str):
         )
         return {"assignments": rows or []}
     except Exception:
+        logger.exception(
+            "Failed to fetch upcoming assignments for user_id=%s today=%s",
+            user_id,
+            today,
+        )
         return {"assignments": []}
 
 
diff --git a/backend/routes/graph.py b/backend/routes/graph.py
@@ -1,5 +1,6 @@
-from fastapi import APIRouter
-from fastapi.responses import JSONResponse
+import logging
+
+from fastapi import APIRouter, HTTPException
 from pydantic import BaseModel
 from typing import Optional
 
@@ -9,25 +10,25 @@
 )
 
 router = APIRouter()
+logger = logging.getLogger(__name__)
 
 
 @router.get("/{user_id}")
 def get_user_graph(user_id: str):
     try:
         return get_graph(user_id)
-    except Exception:
-        return {"nodes": [], "edges": [], "stats": {
-            "total_nodes": 0, "mastered": 0, "learning": 0,
-            "struggling": 0, "unexplored": 0, "streak": 0, "avg_learning_velocity": 0.0,
-        }}
+    except Exception as e:
+        logger.exception("get_graph failed for user_id=%s", user_id)
+        raise HTTPException(status_code=500, detail=str(e) or "Failed to fetch graph")
 
 
 @router.get("/{user_id}/recommendations")
 def get_user_recommendations(user_id: str):
     try:
         return {"recommendations": get_recommendations(user_id)}
-    except Exception:
-        return {"recommendations": []}
+    except Exception as e:
+        logger.exception("get_recommendations failed for user_id=%s", user_id)
+        raise HTTPException(status_code=500, detail=str(e) or "Failed to fetch recommendations")
 
 
 # ── Course endpoints ──────────────────────────────────────────────────────────
diff --git a/backend/tests/test_calendar_routes.py b/backend/tests/test_calendar_routes.py
@@ -137,6 +137,14 @@ def test_returns_empty_list_when_none(self):
         assert r.status_code == 200
         assert r.json()["assignments"] == []
 
+    def test_returns_empty_on_db_failure(self):
+        with patch("routes.calendar.table") as t:
+            t.return_value.select.side_effect = Exception("DB connection error")
+            r = client.get("/api/calendar/upcoming/user_andres")
+
+        assert r.status_code == 200
+        assert r.json() == {"assignments": []}
+
 
 # ── POST /api/calendar/suggest-study-blocks ───────────────────────────────────
 
diff --git a/backend/tests/test_graph_routes.py b/backend/tests/test_graph_routes.py
@@ -0,0 +1,27 @@
+"""
+Unit tests for routes/graph.py
+"""
+
+from unittest.mock import patch
+
+from fastapi.testclient import TestClient
+
+from main import app
+
+client = TestClient(app)
+
+
+class TestGraphRoutes:
+    def test_get_user_graph_returns_500_on_failure(self):
+        with patch("routes.graph.get_graph", side_effect=Exception("graph failed")):
+            r = client.get("/api/graph/user_andres")
+
+        assert r.status_code == 500
+        assert r.json() == {"detail": "graph failed"}
+
+    def test_get_user_recommendations_returns_500_on_failure(self):
+        with patch("routes.graph.get_recommendations", side_effect=Exception("recommendations failed")):
+            r = client.get("/api/graph/user_andres/recommendations")
+
+        assert r.status_code == 500
+        assert r.json() == {"detail": "recommendations failed"}
diff --git a/frontend/src/components/OnboardingFlow.tsx b/frontend/src/components/OnboardingFlow.tsx
@@ -134,22 +134,55 @@ export default function OnboardingFlow({ visible, onClose, onFinish, activeStep,
 
   // Escape key closes
   useEffect(() => {
+    if (!visible) {
+      if (schoolDebounceRef.current) {
+        clearTimeout(schoolDebounceRef.current);
+        schoolDebounceRef.current = null;
+      }
+      return;
+    }
+
     const handler = (e: KeyboardEvent) => { if (e.key === 'Escape') onClose(); };
     window.addEventListener('keydown', handler);
-    return () => window.removeEventListener('keydown', handler);
-  }, [onClose]);
+    return () => {
+      window.removeEventListener('keydown', handler);
+      if (schoolDebounceRef.current) {
+        clearTimeout(schoolDebounceRef.current);
+        schoolDebounceRef.current = null;
+      }
+    };
+  }, [visible, onClose]);
+
+  function handleOptionKeyDown(event: React.KeyboardEvent<HTMLButtonElement>, onSelect: () => void) {
+    if (event.key === 'Enter' || event.key === ' ') {
+      event.preventDefault();
+      onSelect();
+    }
+  }
+
+  function selectSchool(name: string) {
+    setFormData(prev => ({ ...prev, school: name }));
+    setSchoolSuggestions([]);
+  }
+
+  function selectYear(option: string) {
+    setFormData(prev => ({ ...prev, year: option.toLowerCase() }));
+    setYearOpen(false);
+  }
 
   function handleSchoolInput(value: string) {
     setFormData(prev => ({ ...prev, school: value }));
     if (schoolDebounceRef.current) clearTimeout(schoolDebounceRef.current);
     if (value.trim().length < 2) { setSchoolSuggestions([]); return; }
     schoolDebounceRef.current = setTimeout(async () => {
       try {
-        const res = await fetch(`http://universities.hipolabs.com/search?name=${encodeURIComponent(value)}&country=United+States`);
+        const res = await fetch(`https://universities.hipolabs.com/search?name=${encodeURIComponent(value)}&country=United+States`);
         const data: { name: string }[] = await res.json();
         setSchoolSuggestions(data.slice(0, 10).map(u => u.name));
       } catch {
         setSchoolSuggestions([]);
+      } finally {
+        schoolDebounceRef.current = null;
       }
     }, 300);
   }
@@ -409,27 +442,39 @@ export default function OnboardingFlow({ visible, onClose, onFinish, activeStep,
                     maxHeight: '192px', overflowY: 'auto',
                     zIndex: 100,
                     boxShadow: '0 8px 32px rgba(0,0,0,0.12)',
-                  }}>
+                  }} role="listbox" aria-label="School suggestions">
                     {schoolSuggestions.map((name, i) => (
-                      <div key={i}
-                        onMouseDown={() => {
-                          setFormData(prev => ({ ...prev, school: name }));
-                          setSchoolSuggestions([]);
-                        }}
+                      <button
+                        key={i}
+                        type="button"
+                        role="option"
+                        aria-selected={formData.school === name}
+                        onMouseDown={() => selectSchool(name)}
+                        onKeyDown={e => handleOptionKeyDown(e, () => selectSchool(name))}
                         style={{
+                          width: '100%',
+                          textAlign: 'left',
                           padding: '12px 18px',
                           fontSize: '14px',
                           color: '#111827',
                           cursor: 'pointer',
                           borderBottom: i < schoolSuggestions.length - 1 ? '1px solid rgba(0,0,0,0.06)' : 'none',
                           fontFamily: "var(--font-dm-sans), 'DM Sans', sans-serif",
                           transition: 'background 0.15s',
+                          background: formData.school === name ? 'rgba(27,108,66,0.06)' : 'transparent',
+                          borderLeft: 'none',
+                          borderRight: 'none',
+                          borderTop: 'none',
+                        }}
+                        onMouseEnter={e => {
+                          if (formData.school !== name) e.currentTarget.style.background = 'rgba(27,108,66,0.08)';
+                        }}
+                        onMouseLeave={e => {
+                          e.currentTarget.style.background = formData.school === name ? 'rgba(27,108,66,0.06)' : 'transparent';
                         }}
-                        onMouseEnter={e => (e.currentTarget.style.background = 'rgba(27,108,66,0.08)')}
-                        onMouseLeave={e => (e.currentTarget.style.background = 'transparent')}
                       >
                         {name}
-                      </div>
+                      </button>
                     ))}
                   </div>
                 )}
@@ -459,14 +504,18 @@ export default function OnboardingFlow({ visible, onClose, onFinish, activeStep,
                     maxHeight: '192px', overflowY: 'auto',
                     zIndex: 100,
                     boxShadow: '0 8px 32px rgba(0,0,0,0.12)',
-                  }}>
+                  }} role="listbox" aria-label="Class year options">
                     {YEAR_OPTIONS.map((opt, i) => (
-                      <div key={opt}
-                        onMouseDown={() => {
-                          setFormData(prev => ({ ...prev, year: opt.toLowerCase() }));
-                          setYearOpen(false);
-                        }}
+                      <button
+                        key={opt}
+                        type="button"
+                        role="option"
+                        aria-selected={formData.year === opt.toLowerCase()}
+                        onMouseDown={() => selectYear(opt)}
+                        onKeyDown={e => handleOptionKeyDown(e, () => selectYear(opt))}
                         style={{
+                          width: '100%',
+                          textAlign: 'left',
                           padding: '12px 18px',
                           fontSize: '14px',
                           color: formData.year === opt.toLowerCase() ? '#1B6C42' : '#111827',
@@ -476,12 +525,15 @@ export default function OnboardingFlow({ visible, onClose, onFinish, activeStep,
                           fontFamily: "var(--font-dm-sans), 'DM Sans', sans-serif",
                           transition: 'background 0.15s',
                           background: formData.year === opt.toLowerCase() ? 'rgba(27,108,66,0.06)' : 'transparent',
+                          borderLeft: 'none',
+                          borderRight: 'none',
+                          borderTop: 'none',
                         }}
                         onMouseEnter={e => { if (formData.year !== opt.toLowerCase()) e.currentTarget.style.background = 'rgba(27,108,66,0.08)'; }}
                         onMouseLeave={e => { e.currentTarget.style.background = formData.year === opt.toLowerCase() ? 'rgba(27,108,66,0.06)' : 'transparent'; }}
                       >
                         {opt}
-                      </div>
+                      </button>
                     ))}
                   </div>
                 )}
@@ -498,7 +550,6 @@ export default function OnboardingFlow({ visible, onClose, onFinish, activeStep,
               {(['majors', 'minors'] as const).map(field => {
                 const isMinor = field === 'minors';
                 const input = isMinor ? minorInput : majorInput;
-                const setInput = isMinor ? setMinorInput : setMajorInput;
                 const suggestions = isMinor ? minorSuggestions : majorSuggestions;
                 const focused = isMinor ? minorFocused : majorFocused;
                 const setFocused = isMinor ? setMinorFocused : setMajorFocused;
@@ -530,16 +581,29 @@ export default function OnboardingFlow({ visible, onClose, onFinish, activeStep,
                           background: '#ffffff', border: '1px solid rgba(0,0,0,0.1)',
                           borderRadius: '14px', maxHeight: '180px', overflowY: 'auto',
                           zIndex: 100, boxShadow: '0 8px 32px rgba(0,0,0,0.12)',
-                        }}>
+                        }} role="listbox" aria-label={isMinor ? 'Minor suggestions' : 'Major suggestions'}>
                           {suggestions.map((s, i) => (
-                            <div key={i} onMouseDown={() => addItem(s)} style={{
+                            <button
+                              key={i}
+                              type="button"
+                              role="option"
+                              aria-selected={items.includes(s)}
+                              onMouseDown={() => addItem(s)}
+                              onKeyDown={e => handleOptionKeyDown(e, () => addItem(s))}
+                              style={{
+                              width: '100%',
+                              textAlign: 'left',
                               padding: '11px 18px', fontSize: '14px', color: '#111827', cursor: 'pointer',
                               borderBottom: i < suggestions.length - 1 ? '1px solid rgba(0,0,0,0.06)' : 'none',
                               fontFamily: "var(--font-dm-sans), 'DM Sans', sans-serif", transition: 'background 0.15s',
+                              background: 'transparent',
+                              borderLeft: 'none',
+                              borderRight: 'none',
+                              borderTop: 'none',
                             }}
                               onMouseEnter={e => (e.currentTarget.style.background = 'rgba(27,108,66,0.08)')}
                               onMouseLeave={e => (e.currentTarget.style.background = 'transparent')}
-                            >{s}</div>
+                            >{s}</button>
                           ))}
                         </div>
                       )}
diff --git a/linkedin-banner.html b/linkedin-banner.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
 <head>
   <meta charset="utf-8">
   <title>Sapling — LinkedIn Banner</title>
