Skip to content

Remove unused methods in AsymmetricUCB #47

@speculator19

Description

@speculator19

I noticed these two methods in shinka/llm/dynamic_sampling.py that don't seem to be used anywhere:

  • _add_to_reward (lines 204-213)
  • _multiply_reward (lines 215-221)

Did a thorough search and couldn't find any calls to them. They've been there since the initial commit but never actually used. Looks like the code just uses _logadd() and regular operators instead of these methods.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions