Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All links should be links #51

Open
stjohann opened this issue Aug 20, 2023 · 2 comments
Open

All links should be links #51

stjohann opened this issue Aug 20, 2023 · 2 comments

Comments

@stjohann
Copy link

stjohann commented Aug 20, 2023

Currently, <div id="userLinkSpec" ng-click="openLink('diff');" style="color: rgb(51, 102, 187);">AlwynapHuw</div> and <div id="pageLinkSpec" style="cursor: pointer; display: inline-block; color: var(--link-color); border-bottom: unset;" ng-click="openLink('page');">Help:Navigation/cy</div> are coded to behave like links that open in new window, but are not actually links. They should just be links like <a href="…" target="_blank">. Doing otherwise is an accessibility violation and makes the usability of the tool worse (since you can’t do any of the browser actions that are available to links with those links).

There might be other links I did not see in the application that are coded in the same way.

@kfiven
Copy link
Contributor

kfiven commented Aug 21, 2023

In which part you found this link?

@stjohann
Copy link
Author

At the top of diff view for any edit, of course. But you can search yourself in the codebase by looking up openLink or userLinkSpec or pageLinkSpec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants