add more test cases

Author: killpanda

README.md

@@ -1,6 +1,6 @@
 # flask-zipkin
 
-a flask zipkin extesion based on py_zipkin.
+a flask zipkin extension based on py_zipkin.
 
 ## Installation
 
@@ -23,7 +23,7 @@ zipkin.init_app(app)
 
 you could gen a header to pass it to other services, the downstream service will recieve this header.
 
-```
+```python
 @bp.route('/')
 def hello():
     headers = {}

flask_zipkin.py

@@ -98,7 +98,7 @@ def _before_request(self):
 
         span = zipkin.zipkin_span(
             service_name=self.app.name,
-            span_name='{0}.{1}'.format(request.endpoint, request.mehod),
+            span_name='{0}.{1}'.format(request.endpoint, request.method),
             transport_handler=handler,
             sample_rate=self._sample_rate,
             zipkin_attrs=zipkin_attrs

test_flask_zipkin.py

@@ -4,7 +4,7 @@
 import unittest
 import mock
 
-from flask import Flask
+import flask
 from flask_zipkin import Zipkin
 
 
@@ -15,27 +15,48 @@ def handle_transport(*kargs, **kwargs):
 class FlaskZipkinTestCase(unittest.TestCase):
 
     def setUp(self):
-        app = Flask(__name__)
+        app = flask.Flask(__name__)
         app.testing = True
         app.config['ZIPKIN_DISABLE'] = False
         app.config['ZIPKIN_DSN'] = 'whatever'
 
+        bp = flask.Blueprint('bp', __name__, url_prefix='/bp')
+
+        @app.route('/foo')
+        def foo():
+            return 'bar'
+
+        @bp.route('/bar')
+        def bar():
+            return 'foo'
+
         z = Zipkin()
-        z.init_app(app)
         z._transport_handler = handle_transport
 
         self.z = z
         self.app = app
-
-        @app.route('/foo')
-        def foo():
-            return 'bar'
+        self.app.register_blueprint(bp)
+        z.init_app(self.app)
 
     @mock.patch('py_zipkin.zipkin.create_endpoint')
     def test_normal_get(self, create_endpoint_mock):
         rv = self.app.test_client().get('/foo')
         assert rv.status_code == 200
 
+    @mock.patch('py_zipkin.zipkin.create_endpoint')
+    def test_flask_request_context_with_app(self, create_endpoint_mock):
+        with self.app.test_request_context('/foo'):
+            self.app.preprocess_request()
+            assert flask.g._zipkin_span
+            assert flask.g._zipkin_span.span_name == 'foo.GET'
+
+    @mock.patch('py_zipkin.zipkin.create_endpoint')
+    def test_flask_request_context_with_bp(self, create_endpoint_mock):
+        with self.app.test_request_context('/bp/bar'):
+            self.app.preprocess_request()
+            assert flask.g._zipkin_span
+            assert flask.g._zipkin_span.span_name == 'bp.bar.GET'
+
 
 def suite():
     suite = unittest.TestSuite()