[Improve] code quaility as per SQ suggestions

Author: sam.gerene

SysML2.NET.CodeGenerator/Extensions/EcoreExtensions.cs

@@ -37,7 +37,7 @@ public static class EcoreExtensions
         /// <summary>
         /// A mapping of the known SysML value types to C# types
         /// </summary>
-        public static readonly Dictionary<string, string> TypeMapping = new Dictionary<string, string>
+        private static readonly Dictionary<string, string> TypeMapping = new Dictionary<string, string>
         {
             {"Boolean", "bool"},
             {"Integer", "int"},
@@ -92,10 +92,7 @@ public static bool QueryIsEnum(this EStructuralFeature eStructuralFeature)
         {
             if (eStructuralFeature is EAttribute eAttribute)
             {
-                if (eAttribute.EType is EEnum)
-                {
-                    return true;
-                }
+                return eAttribute.EType is EEnum;
             }
 
             return false;

SysML2.NET.CodeGenerator/Generators/HandleBarsGenerators/DtoSerializerGenerator.cs

@@ -98,7 +98,7 @@ public async Task GenerateSerializationProvider(EPackage package, DirectoryInfo
         {
             var template = this.Templates["dto-serialization-provider-template"];
 
-            var eClasses = package.EClassifiers.OfType<EClass>().Where(x => !x.Abstract).OrderBy(x => x.Name).ToList().ToList();
+            var eClasses = package.EClassifiers.OfType<EClass>().Where(x => !x.Abstract).OrderBy(x => x.Name).ToList();
 
             var generatedSerializationProvider = template(eClasses);
 

SysML2.NET.Serializer.Json.Tests/SerializerTestFixture.cs

@@ -73,7 +73,7 @@ public void Verify_that_Elements_can_be_serialized()
             var stream = new MemoryStream();
             var jsonWriterOptions = new JsonWriterOptions { Indented = true };
 
-            this.serializer.Serialize(elements, SerializationModeKind.JSON, stream, jsonWriterOptions);
+            Assert.That(() => this.serializer.Serialize(elements, SerializationModeKind.JSON, stream, jsonWriterOptions), Throws.Nothing); ;
 
             string json = Encoding.UTF8.GetString(stream.ToArray());
             Console.WriteLine(json);

SysML2.NET.Serializer.Json/DeSerializer.cs

@@ -21,6 +21,7 @@
 namespace SysML2.NET.Serializer.Json
 {
     using System.Collections.Generic;
+    using System.Diagnostics;
     using System.IO;
     using System.Text.Json;
 
@@ -72,15 +73,17 @@ public DeSerializer(ILoggerFactory loggerFactory = null)
         /// </returns>
         public IEnumerable<IElement> DeSerialize(Stream stream, SerializationModeKind serializationModeKind)
         {
+            var sw = Stopwatch.StartNew();
+
             var result = new List<IElement>();
 
-            using (JsonDocument document = JsonDocument.Parse(stream))
+            using (var document = JsonDocument.Parse(stream))
             {
-                JsonElement root = document.RootElement;
+                var root = document.RootElement;
 
-                foreach (JsonElement jsonElement in root.EnumerateArray())
+                foreach (var jsonElement in root.EnumerateArray())
                 {
-                    if (jsonElement.TryGetProperty("@type", out JsonElement typeElement))
+                    if (jsonElement.TryGetProperty("@type", out var typeElement))
                     {
                         var typeName = typeElement.GetString();
 
@@ -91,6 +94,8 @@ public IEnumerable<IElement> DeSerialize(Stream stream, SerializationModeKind se
                 }
             }
 
+            this.logger.LogInformation($"stream deserialized in {sw.ElapsedMilliseconds} [ms]");
+
             return result;
         }
     }