[Add] logging statements to API deserializers

[Add] improve code as per SQ suggestions

Author: sam.gerene

SysML2.NET.Serializer.Json/API/BranchDeserializer.cs

@@ -63,6 +63,8 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin
                 throw new InvalidOperationException($"The BranchDeserializer can only be used to deserialize objects of type Branch, a {@type.GetString()} was provided");
             }
 
+            logger.Log(LogLevel.Trace, "start deserialization: Branch");
+
             var dtoInstance = new SysML2.NET.API.DTO.Branch();
 
             if (jsonElement.TryGetProperty("@id", out JsonElement idProperty))
@@ -184,6 +186,8 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin
                 logger.LogDebug($"the timestamp Json property was not found in the Branch: {dtoInstance.Id}");
             }
 
+            logger.Log(LogLevel.Trace, "finish deserialization: Branch");
+
             return dtoInstance;
         }
     }

SysML2.NET.Serializer.Json/API/CommitDeSerializer.cs

@@ -63,6 +63,8 @@ internal static Commit DeSerialize(JsonElement jsonElement, SerializationModeKin
                 throw new InvalidOperationException($"The CommitDeSerializer can only be used to deserialize objects of type Commit, a {@type.GetString()} was provided");
             }
 
+            logger.Log(LogLevel.Trace, "start deserialization: Commit");
+
             var dtoInstance = new SysML2.NET.API.DTO.Commit();
 
             if (jsonElement.TryGetProperty("@id", out JsonElement idProperty))
@@ -157,6 +159,8 @@ internal static Commit DeSerialize(JsonElement jsonElement, SerializationModeKin
                 logger.LogDebug($"the timestamp Json property was not found in the Commit: {dtoInstance.Id}");
             }
 
+            logger.Log(LogLevel.Trace, "finish deserialization: Commit");
+
             return dtoInstance;
         }
     }

SysML2.NET.Serializer.Json/API/DataIdentityDeSerializer.cs

@@ -63,6 +63,8 @@ internal static DataIdentity DeSerialize(JsonElement jsonElement, SerializationM
                 throw new InvalidOperationException($"The DataIdentityDeSerializer only be used to deserialize objects of type DataIdentity, a {@type.GetString()} was provided");
             }
 
+            logger.Log(LogLevel.Trace, "start deserialization: DataIdentity");
+
             var dtoInstance = new SysML2.NET.API.DTO.DataIdentity();
 
             if (jsonElement.TryGetProperty("@id", out JsonElement idPropertyVersionItem))
@@ -76,6 +78,8 @@ internal static DataIdentity DeSerialize(JsonElement jsonElement, SerializationM
                 dtoInstance.Id = Guid.Parse(idPropertyVersionItemValue);
             }
 
+            logger.Log(LogLevel.Trace, "finish deserialization: DataIdentity");
+
             return dtoInstance;
         }
     }

SysML2.NET.Serializer.Json/API/DataVersionDeSerializer.cs

@@ -52,7 +52,9 @@ internal static class DataVersionDeSerializer
         internal static DataVersion DeSerialize(JsonElement jsonElement, SerializationModeKind serializationModeKind, ILoggerFactory loggerFactory = null)
         {
             var logger = loggerFactory == null ? NullLogger.Instance : loggerFactory.CreateLogger("DataVersionDeSerializer");
-            
+
+            logger.Log(LogLevel.Trace, "start deserialization: DataVersion");
+
             var dtoInstance = new SysML2.NET.API.DTO.DataVersion();
 
             if (jsonElement.TryGetProperty("@id", out JsonElement idPropertyVersionItem))
@@ -90,6 +92,8 @@ internal static DataVersion DeSerialize(JsonElement jsonElement, SerializationMo
                 logger.LogDebug($"the payload Json property was not found in the DataVersion: {dtoInstance.Id}");
             }
 
+            logger.Log(LogLevel.Trace, "finish deserialization: DataVersion");
+
             return dtoInstance;
         }
     }

SysML2.NET.Serializer.Json/API/ProjectDeSerializer.cs

@@ -63,6 +63,8 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi
                 throw new InvalidOperationException($"The ProjectDeSerializer can only be used to deserialize objects of type Project, a {@type.GetString()} was provided");
             }
 
+            logger.Log(LogLevel.Trace, "start deserialization: Project");
+
             var dtoInstance = new SysML2.NET.API.DTO.Project();
 
             if (jsonElement.TryGetProperty("@id", out JsonElement idProperty))
@@ -143,6 +145,8 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi
                 logger.LogDebug($"the name Json property was not found in the Project: {dtoInstance.Id}");
             }
 
+            logger.Log(LogLevel.Trace, "finish deserialization: Project");
+
             return dtoInstance;
         }
     }

SysML2.NET.Serializer.Json/API/TagDeserializer.cs

@@ -63,6 +63,8 @@ internal static Tag DeSerialize(JsonElement jsonElement, SerializationModeKind s
                 throw new InvalidOperationException($"The TagDeserializer can only be used to deserialize objects of type Tag, a {@type.GetString()} was provided");
             }
 
+            logger.Log(LogLevel.Trace, "start deserialization: Tag");
+
             var dtoInstance = new SysML2.NET.API.DTO.Tag();
 
             if (jsonElement.TryGetProperty("@id", out JsonElement idProperty))
@@ -166,6 +168,8 @@ internal static Tag DeSerialize(JsonElement jsonElement, SerializationModeKind s
                 logger.LogDebug($"the timestamp Json property was not found in the Tag: {dtoInstance.Id}");
             }
 
+            logger.Log(LogLevel.Trace, "finish deserialization: Tag");
+
             return dtoInstance;
         }
     }

SysML2.NET.Viewer/ViewModels/Components/LoginViewModel.cs

@@ -46,7 +46,7 @@ public class LoginViewModel : ReactiveObject, ILoginViewModel
         /// <summary>
         /// The (dependency) injected <see cref="IRestClient"/>
         /// </summary>
-        private IRestClient restClient;
+        private readonly IRestClient restClient;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="LoginViewModel"/>