Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design space implementations should be in separate files #6

Open
relf opened this issue Oct 18, 2024 · 0 comments
Open

Design space implementations should be in separate files #6

relf opened this issue Oct 18, 2024 · 0 comments
Assignees
@Paul-Saves

Comments

@relf
Copy link
Member

relf commented Oct 18, 2024

At the moment, design_space.py contains two DesignSpace implementations:

  • DesignSpace based on ConfigSpace
  • DesignSpaceGraph based on ADSG

These classes should be put in separate files and should be renamed to reflect their specialization (ConfigSpaceDesignSpaceImpl ?, AdsgDesignSpaceImpl ?)
@Paul-Saves Paul-Saves self-assigned this Oct 21, 2024
Paul-Saves added a commit that referenced this issue Oct 23, 2024
@Paul-Saves
Merge pull request #7 from SMTorg/dev
d3b4dbe 
Solve #6 by renaming the class and improving the tests and initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Paul-Saves Paul-Saves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@relf @Paul-Saves