Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui container: invalid openssl option in NODE_OPTIONS #126

Open
sebix opened this issue Feb 17, 2023 · 4 comments
Open

gui container: invalid openssl option in NODE_OPTIONS #126

sebix opened this issue Feb 17, 2023 · 4 comments

Comments

@sebix
Copy link
Contributor

sebix commented Feb 17, 2023

At building the gui container using branch main, I get the following error:

Step 11/24 : ENV NODE_OPTIONS=--openssl-legacy-provider
 ---> Running in 23162772aedd
Removing intermediate container 23162772aedd
 ---> 27f722440ae2
Step 12/24 : RUN npm run build
 ---> Running in e8580fc51d6b
node: --openssl-legacy-provider is not allowed in NODE_OPTIONS
The command '/bin/sh -c npm run build' returned a non-zero code: 9
ERROR: Service 'gui' failed to build : Build failed

This is the affected code:

ENV NODE_OPTIONS=--openssl-legacy-provider
RUN npm run build

Removing the env lets the build succeed.

There wasn't a change in this Dockerfile since November, so maybe an updated package causes this now?
If you can reproduce the issue and think that removing ENV NODE_OPTIONS=--openssl-legacy-provider is the correct solution, I can create a PR fixing it.

@dodancs
Copy link
Collaborator

dodancs commented Feb 17, 2023

Hi @sebix , have you tried pulling the latest base image? This was added because newer versions of node had issues building the GUI without it! Try running this before building the container:

docker pull node:lts-alpine

or try updating also all base images with:

docker-compose -f docker/docker-compose.yml build --pull

see: #108

@sebix
Copy link
Contributor Author

sebix commented Feb 17, 2023

I forgot to add that I used branch main.

If a specific version of the docker image is required, I suggest adding the required tag to the Dockerfile

@dodancs
Copy link
Collaborator

dodancs commented Feb 17, 2023

Well, I think we should always stay up to date, and fix these kinds of issues step by step. But yeah, it is a good suggestion to stabilize the version so that when somebody tries to build the containers with outdated images, it will automatically grab the new ones.

@sebix
Copy link
Contributor Author

sebix commented Feb 17, 2023

Well, I think we should always stay up to date,

I fully agree with you.

If the docker image would provide lts-like tags / major version tags, so that security updates are automatically pulled, but no breaking updates, that'd be ideal. But for alpine these are dreams :D

milankowww pushed a commit that referenced this issue Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants