Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400 (Bad request) on accepting or rejecting a service provider to a game #116

Open
tarekmorsi opened this issue May 1, 2017 · 9 comments

Comments

@tarekmorsi
Copy link

tarekmorsi commented May 1, 2017

1- Severity --> Medium
2- Reported by --> Tarek Morsi

3- Upon accepting a service provider to a game, an alert is displayed with an unexplained message and the application crashes (any type of action afterwards, like routing or clicking any button displays a colossal amount of errors in the console).

screenshot 79

screenshot 80

4- Steps to Produce The Issue:
a. open the website
b. sign in as a service provider
c. go to /games and request to join a game.
d. sign out and sign back in as a player
e. accept the service provider to the game.

5- Expected to be accepted to the game and be shown a message that the request was accepted or rejected (in case of an error, an error should be displayed.)

@mahmoud-adel-mahmoud
Copy link
Collaborator

It seems to be that the server isn't crashed

@minaamir26
Copy link
Collaborator

The title should be descriptive, the app does not crash it is working normally
The error gets back from the backend, you can see it in the response in the Networks tab (the error code is 400) but its message is not displayed, that's it all
The severity is not high as written, you can see the doctor's documentation on slack channel for the severity

@tarekmorsi
Copy link
Author

tarekmorsi commented May 1, 2017

My mistake, let me rephrase what I was saying and back my words up with a few more screenshots.

@tarekmorsi tarekmorsi changed the title Application crashes on accepting or rejecting a service provider to a game 400 (Bad request) on accepting or rejecting a service provider to a game May 1, 2017
@minaamir26
Copy link
Collaborator

It is not an error by the way, we are who sending this message with this code in the backend, our only mistake was just we had not displayed the message to the user

@mahmoud-adel-mahmoud
Copy link
Collaborator

Excuse me, but the severity is now medium not high as mentioned

@El-Etreby
Copy link

screen shot 2017-05-01 at 9 38 07 pm

screen shot 2017-05-01 at 9 38 13 pm

screen shot 2017-05-01 at 9 38 35 pm

I do think that severity should be high since the application did crash when i tried the same steps, most probably that issue occurs whenever the user accepts the game requested by a provider.

@minaamir26
Copy link
Collaborator

Application crashes means that : you will not be able to open the website at all after the bug is detected :D but if you go to the website again and type the url, you will be able to continue

@El-Etreby
Copy link

According to the announcement on slack "severe: causes the application crashes- application generates an incorrect response
medium: the user is left with no feedback after successful completion of an operation. A transaction is completed yet incurs considerable delay." I am pretty sure that this issue isnt medium, in fact it is severe since the application generates an incorrect response whenever the user accepts the game requested by the provider.

@mahmoud-adel-mahmoud
Copy link
Collaborator

Generating wrong response means redirecting you to a wrong page.
But our case is an error confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants