Skip to content

fix unstable fiori tools settings test #3864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 27, 2025
Merged

fix unstable fiori tools settings test #3864

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7b9b01
fix unstable test
devinea Nov 25, 2025
2537878
refactor: comment out fs existence check in writeApplicationInfoSetti…
devinea Nov 25, 2025
0e704c5
refactor: clean up test setup by ensuring appInfo.json is deleted bef…
devinea Nov 25, 2025
7bef816
Feedback
devinea Nov 26, 2025
d84920a
cleanup
devinea Nov 26, 2025
04927b5
Merge branch 'main' into fix_fiori-tools-settings-test
longieirl Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/fiori-tools-settings/test/applicationInfoHandler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,17 @@ import {
appInfoFilePath,
defaultAppInfoContents
} from '../src';
import { promises as fsPromises } from 'node:fs';

describe('Application Info Settings', () => {
let fs: Editor;

beforeEach(() => {
beforeEach(async () => {
// Ensure a clean state before each test
await fsPromises.rm(appInfoFilePath).catch(() => {
// Ignore errors if the file does not exist
});

fs = create(createStorage());
});

Expand Down
Loading