incorporated review comments

Author: SreevishnuAB

sap/aibus/dar/client/model_manager_client.py

@@ -131,10 +131,9 @@ def read_job_by_model_name(self, model_name: str) -> dict:
         for job in jobs:
             if job["modelName"] == model_name:
                 return job
-        else:  # pylint: disable=useless-else-on-loop
-            raise JobNotFound(
-                "Job with model name '{}' could not be found".format(model_name)
-            )
+        raise JobNotFound(
+            "Job with model name '{}' could not be found".format(model_name)
+        )
 
     def delete_job_by_id(self, job_id: str) -> None:
         """

system_tests/workflow/test_end_to_end.py

@@ -143,19 +143,13 @@ def test_create(
         # Job
         # The Model resource does not have a jobId property, so we
         # have to look up the job ID via the job collection
-        job_collection = model_manager_client.read_job_collection()
-        job_id = None
-        for job in job_collection["jobs"]:
-            if job["modelName"] == model_name:
-                job_id = job["id"]
-                break
-        assert job_id is not None
+        job = model_manager_client.read_job_by_model_name(model_name)
+        assert job["id"] is not None
+        job_id = job["id"]
 
         self._assert_job_exists(model_manager_client, job_id)
         # Get dataset ID used in this job
         job_resource = model_manager_client.read_job_by_id(job_id)
-        job_by_name = model_manager_client.read_job_by_model_name(model_name)
-        assert job_by_name is not None
         dataset_id = job_resource["datasetId"]
         # Clean up job
         model_manager_client.delete_job_by_id(job_id)