Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pixl_dcmd into pixl_core #359

Open
jeremyestein opened this issue Mar 26, 2024 · 2 comments
Open

Merge pixl_dcmd into pixl_core #359

jeremyestein opened this issue Mar 26, 2024 · 2 comments

Comments

@jeremyestein
Copy link
Contributor

From pixl_dcmd/README.md:

The reason for having this as a separate package instead of having the functionality in pixl_core is because orthanc requires Python 3.9, whereas the rest of PIXL is on 3.10 or higher.

Since we're now on 3.11 for everything, I think pixl_dcmd can be merged into pixl_core, to reduce the number of packages we have and make things a bit easier to work with.

@milanmlft
Copy link
Member

Note, from #361, it looks like there is some clash between pixl_dcmd/tests/conftest.py and hasher/tests/conftest.py.
Might be worth resolving this together with the merge.

@jeremyestein
Copy link
Contributor Author

If you're refactoring this area anyway, you might consider moving some of the not publicly called methods in pixl_dcmd/src/pixl_dcmd/main.py into one of the private modules adjacent to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants