Overlay Tooltip bug when Contract Configurator 1.30.x is present

[Sinomen]

Hey DMagic,

The other day I stumbled over a strange bug, using ScanSat 20.4 together with Nightingale's Contract Configurator 1.30.4:

With both mods present, when I enable a CB overlay (Terrain, Biome, Ore, doesn't matter which), the ScanSat tooltip under the mouse point flickers and alternates with the remaining mission time of any CC contract.

Nightingale could reproduce the issue, please take a look here:

https://forum.kerbalspaceprogram.com/index.php?/topic/91625-1101-contract-configurator-v1304-2020-09-21/page/193/&tab=comments#comment-3859388

I'd be happy if you would take a look at this, thanks in advance for your time and efforts.

[Sinomen]

Hey DMagic,

I've seen this issue yesterday too when another player streamed KSP on Twitch. Just curious: did you find time yet to look what is causing this issue?

[johnabsher]

Just a +1 to this - I also have been running into this issue.

[abel1502]

I think the issue is caused by SCANToStringAndRelease here:

SCANsat/SCANsat/SCAN_UI/UI_Framework/SCANStringBuilderCache.cs

Lines 28 to 40 in e2d7bde

	public static void SCANRelease(this StringBuilder sb)
	{
	if (sb.Capacity <= 360)
	CachedBuilder = sb;
	}
	public static string SCANToStringAndRelease(this StringBuilder sb)
	{
	string s = sb.ToString();
	sb.Release();
	return s;
	}
	}

The string builder is released into the global Unity cache instead of the ScanSat-specific one. Then it is, apparently, picked up again by some of the code from ContractConfigurator and reused for the mission remaining time.

It can be fixed by replacing sb.Release(); with sb.SCANRelease();, I think