Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Enhance functionality for note creation and path handling #305

Open
SSmJaE opened this issue Nov 29, 2024 · 0 comments
Open

[FR] Enhance functionality for note creation and path handling #305

SSmJaE opened this issue Nov 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@SSmJaE
Copy link

SSmJaE commented Nov 29, 2024

Describe your request

Current Issues

1. Limited Command Functionality

Currently, when using PDF++ commands, it only allows creating new notes. We need a dedicated command that:

  • Only opens existing corresponding notes
  • Doesn't perform any additional operations

2. Path Resolution Issues

There's a problem with note generation paths when a specific folder path is configured:

  • When a new folder path is specified in settings
  • New note paths are incorrectly concatenated from the specified folder instead of starting from the vault root directory

Expected Behavior

Command Enhancement

  • Add a new command that specifically handles opening existing notes
  • Keep the current note creation functionality separate
  • Allow users to choose between creating new notes or opening existing ones

Path Resolution

  • All paths should be resolved from the vault root directory
  • When specific folders are configured, the path should still maintain proper resolution from root
  • Example:
    • Vault root: /
    • New note folder path: /!uncategorized/
    • Plugin configured folder: /academic/_notes/
    • New note path should be: /academic/_notes/note.md (absolute path)
    • Current behavior: !uncategorized/academic/_notes/note.md (incorrect concatenation)
@SSmJaE SSmJaE added the enhancement New feature or request label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant