Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aead: move STREAM implementation into a separate crate? #1665

Open
newpavlov opened this issue Sep 12, 2024 · 1 comment
Open

aead: move STREAM implementation into a separate crate? #1665

newpavlov opened this issue Sep 12, 2024 · 1 comment
Labels
aead Authenticated Encryption with Associated Data (AEAD) crate

Comments

@newpavlov
Copy link
Member

newpavlov commented Sep 12, 2024

STREAM is an authenticated encryption construction. In future we may support other similar constructions and it feels a bit weird to have an algorithm implementation in a trait crate. I suggest to move the implementation into a separate crate which will be developed in the AEADs repository. Doing so will also reduce number of crate features in the aead crate. For better discoverability we can mention the new crate in aead docs.

UPD: I see that we already have the aead-stream crate registered.

@newpavlov newpavlov added the aead Authenticated Encryption with Associated Data (AEAD) crate label Sep 12, 2024
@tarcieri
Copy link
Member

it feels a bit weird to have an algorithm implementation in a trait crate.

It also has important trait components: https://docs.rs/aead/latest/aead/stream/trait.StreamPrimitive.html

In future we may support other similar constructions

Well, that trait is designed to not only support a family of similar constructions, but even makes it possible to plug in your own.

That said, I'm not opposed to extracting an aead-stream crate.

@tarcieri tarcieri changed the title Move STREAM implementation into a separate crate? aead: move STREAM implementation into a separate crate? Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aead Authenticated Encryption with Associated Data (AEAD) crate
Projects
None yet
Development

No branches or pull requests

2 participants