Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rand_core v0.9 support #1642

Open
tarcieri opened this issue Aug 8, 2024 · 2 comments
Open

rand_core v0.9 support #1642

tarcieri opened this issue Aug 8, 2024 · 2 comments

Comments

@tarcieri
Copy link
Member

tarcieri commented Aug 8, 2024

I tried bumping this repo to rand_core v0.9.0-alpha.2 and ran into the following problem:

This release gets rid of CryptoRngCore and instead changes CryptoRng to have RngCore as a supertrait.

It also splits out TryRngCore into a separate trait, so we can't simply replace CryptoRngCore with CryptoRng and still have access to try_fill_bytes.

What should we do?

  1. Request upstream change to CryptoRng to have a supertrait bound on TryRngCore
  2. Switch to CryptoRng and fill_bytes and get rid of fallible errors when using rand_core-based APIs (we still have fallibility for getrandom-based APIs)
  3. Switch from CryptoRngCore to bounds of CryptoRng + TryRngCore
@tarcieri
Copy link
Member Author

tarcieri commented Aug 8, 2024

I think option 2 is probably the most straightforward. It's pretty much where we were before, and we have also added getrandom-based fallible APIs.

@newpavlov
Copy link
Member

newpavlov commented Aug 8, 2024

I think we can have two sets of methods: one set based on CryptoRng and another set of try_* methods based on TryCryptoRng. Note that fallible RNGs should implement the Try* traits, while potentially fallible ones can be converted to "infallible" using the UnwrapErr wrapper. Users then can decide what to use by themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants