Update to PrimeField::from_repr() changes

daxpedda · daxpedda · commit eec6bbaa4c7d · 2025-05-29T13:16:05.000+02:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -37,6 +37,7 @@ rfc6979 = { git = "https://github.com/RustCrypto/signatures.git" }
 # https://github.com/RustCrypto/traits/pull/1777
 # https://github.com/RustCrypto/traits/pull/1845
 digest = { git = "https://github.com/RustCrypto/traits.git" }
-elliptic-curve = { git = "https://github.com/RustCrypto/traits.git" }
+elliptic-curve = { git = "https://github.com/RustCrypto/traits.git", rev = "238fa0841040acb8a8b0a7c50a66adcaa847d28a" }
+ff = { git = "https://github.com/zkcrypto/ff.git", rev = "8e139e2fb25ab61a5d362394af0a34b10c03d59b" }
 signature = { git = "https://github.com/RustCrypto/traits.git" }
 
diff --git a/bign256/benches/scalar.rs b/bign256/benches/scalar.rs
@@ -8,22 +8,22 @@ use hex_literal::hex;
 
 fn test_scalar_x() -> Scalar {
     Scalar::from_repr(
-        hex!("519b423d715f8b581f4fa8ee59f4771a5b44c8130b4e3eacca54a56dda72b464").into(),
+        &hex!("519b423d715f8b581f4fa8ee59f4771a5b44c8130b4e3eacca54a56dda72b464").into(),
     )
     .unwrap()
 }
 
 fn test_scalar_y() -> Scalar {
     Scalar::from_repr(
-        hex!("0f56db78ca460b055c500064824bed999a25aaf48ebb519ac201537b85479813").into(),
+        &hex!("0f56db78ca460b055c500064824bed999a25aaf48ebb519ac201537b85479813").into(),
     )
     .unwrap()
 }
 
 fn bench_point_mul<M: Measurement>(group: &mut BenchmarkGroup<M>) {
     let p = ProjectivePoint::GENERATOR;
     let m = test_scalar_x();
-    let s = Scalar::from_repr(m.into()).unwrap();
+    let s = Scalar::from_repr(&m.into()).unwrap();
     group.bench_function("point-scalar mul", |b| b.iter(|| p * s));
 }
 
diff --git a/bign256/src/arithmetic/field.rs b/bign256/src/arithmetic/field.rs
@@ -94,8 +94,8 @@ impl PrimeField for FieldElement {
     type Repr = FieldBytes;
 
     #[inline]
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        Self::from_bytes(&bytes)
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        Self::from_bytes(bytes)
     }
 
     #[inline]
diff --git a/bign256/src/arithmetic/scalar.rs b/bign256/src/arithmetic/scalar.rs
@@ -130,8 +130,8 @@ impl IsHigh for Scalar {
 impl PrimeField for Scalar {
     type Repr = FieldBytes;
 
-    fn from_repr(repr: Self::Repr) -> CtOption<Self> {
-        Self::from_bytes(&repr)
+    fn from_repr(repr: &Self::Repr) -> CtOption<Self> {
+        Self::from_bytes(repr)
     }
 
     fn to_repr(&self) -> Self::Repr {
diff --git a/bign256/src/ecdsa/signing.rs b/bign256/src/ecdsa/signing.rs
@@ -112,7 +112,7 @@ impl PrehashSigner<Signature> for SigningKey {
         let h = Scalar::reduce_bytes(&h_word);
 
         //2. Generate 𝑘 ← rand(1,..,𝑞-1)
-        let k = Scalar::from_repr(rfc6979::generate_k::<BeltHash, _>(
+        let k = Scalar::from_repr(&rfc6979::generate_k::<BeltHash, _>(
             &self.secret_scalar.to_repr(),
             &FieldBytesEncoding::<BignP256>::encode_field_bytes(&BignP256::ORDER),
             &h.to_bytes(),
diff --git a/bp256/src/arithmetic/field.rs b/bp256/src/arithmetic/field.rs
@@ -90,8 +90,8 @@ impl PrimeField for FieldElement {
     const DELTA: Self = Self::from_u64(121);
 
     #[inline]
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        Self::from_bytes(&bytes)
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        Self::from_bytes(bytes)
     }
 
     #[inline]
diff --git a/bp256/src/arithmetic/scalar.rs b/bp256/src/arithmetic/scalar.rs
@@ -116,8 +116,8 @@ impl PrimeField for Scalar {
     const DELTA: Self = Self::from_u64(9);
 
     #[inline]
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        Self::from_bytes(&bytes)
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        Self::from_bytes(bytes)
     }
 
     #[inline]
diff --git a/bp384/src/arithmetic/field.rs b/bp384/src/arithmetic/field.rs
@@ -93,8 +93,8 @@ impl PrimeField for FieldElement {
     const DELTA: Self = Self::from_u64(9);
 
     #[inline]
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        Self::from_bytes(&bytes)
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        Self::from_bytes(bytes)
     }
 
     #[inline]
diff --git a/bp384/src/arithmetic/scalar.rs b/bp384/src/arithmetic/scalar.rs
@@ -124,8 +124,8 @@ impl PrimeField for Scalar {
     const DELTA: Self = Self::from_u64(16);
 
     #[inline]
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        Self::from_bytes(&bytes)
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        Self::from_bytes(bytes)
     }
 
     #[inline]
diff --git a/k256/benches/ecdsa.rs b/k256/benches/ecdsa.rs
@@ -14,7 +14,7 @@ use std::hint::black_box;
 fn test_scalar_d() -> NonZeroScalar {
     NonZeroScalar::new(
         Scalar::from_repr(
-            [
+            &[
                 0xbb, 0x48, 0x8a, 0xef, 0x41, 0x6a, 0x41, 0xd7, 0x68, 0x0d, 0x1c, 0xf0, 0x1d, 0x70,
                 0xf5, 0x9b, 0x60, 0xd7, 0xf5, 0xf7, 0x7e, 0x30, 0xe7, 0x8b, 0x8b, 0xf9, 0xd2, 0xd8,
                 0x82, 0xf1, 0x56, 0xa6,
diff --git a/k256/benches/scalar.rs b/k256/benches/scalar.rs
@@ -12,7 +12,7 @@ use std::hint::black_box;
 
 fn test_scalar_x() -> Scalar {
     Scalar::from_repr(
-        [
+        &[
             0xbb, 0x48, 0x8a, 0xef, 0x41, 0x6a, 0x41, 0xd7, 0x68, 0x0d, 0x1c, 0xf0, 0x1d, 0x70,
             0xf5, 0x9b, 0x60, 0xd7, 0xf5, 0xf7, 0x7e, 0x30, 0xe7, 0x8b, 0x8b, 0xf9, 0xd2, 0xd8,
             0x82, 0xf1, 0x56, 0xa6,
@@ -24,7 +24,7 @@ fn test_scalar_x() -> Scalar {
 
 fn test_scalar_y() -> Scalar {
     Scalar::from_repr(
-        [
+        &[
             0x67, 0xe2, 0xf6, 0x80, 0x71, 0xed, 0x82, 0x81, 0xe8, 0xae, 0xd6, 0xbc, 0xf1, 0xc5,
             0x20, 0x7c, 0x5e, 0x63, 0x37, 0x22, 0xd9, 0x20, 0xaf, 0xd6, 0xae, 0x22, 0xd0, 0x6e,
             0xeb, 0x80, 0x35, 0xe3,
@@ -37,7 +37,7 @@ fn test_scalar_y() -> Scalar {
 fn bench_point_mul<M: Measurement>(group: &mut BenchmarkGroup<'_, M>) {
     let p = ProjectivePoint::GENERATOR;
     let m = hex!("AA5E28D6A97A2479A65527F7290311A3624D4CC0FA1578598EE3C2613BF99522");
-    let s = Scalar::from_repr(m.into()).unwrap();
+    let s = Scalar::from_repr(&m.into()).unwrap();
     group.bench_function("point-scalar mul", |b| {
         b.iter(|| black_box(p) * black_box(s))
     });
@@ -46,7 +46,7 @@ fn bench_point_mul<M: Measurement>(group: &mut BenchmarkGroup<'_, M>) {
 fn bench_point_lincomb<M: Measurement>(group: &mut BenchmarkGroup<'_, M>) {
     let p = ProjectivePoint::GENERATOR;
     let m = hex!("AA5E28D6A97A2479A65527F7290311A3624D4CC0FA1578598EE3C2613BF99522");
-    let s = Scalar::from_repr(m.into()).unwrap();
+    let s = Scalar::from_repr(&m.into()).unwrap();
     group.bench_function("lincomb via mul+add", |b| {
         b.iter(|| black_box(p) * black_box(s) + black_box(p) * black_box(s))
     });
diff --git a/k256/src/arithmetic/field.rs b/k256/src/arithmetic/field.rs
@@ -317,8 +317,8 @@ impl PrimeField for FieldElement {
     ]));
     const DELTA: Self = Self::from_u64(9);
 
-    fn from_repr(repr: Self::Repr) -> CtOption<Self> {
-        Self::from_bytes(&repr)
+    fn from_repr(repr: &Self::Repr) -> CtOption<Self> {
+        Self::from_bytes(repr)
     }
 
     fn to_repr(&self) -> Self::Repr {
diff --git a/k256/src/arithmetic/projective.rs b/k256/src/arithmetic/projective.rs
@@ -912,7 +912,7 @@ mod tests {
                 MUL_TEST_VECTORS
                     .iter()
                     .cloned()
-                    .map(|(k, x, y)| (Scalar::from_repr(k.into()).unwrap(), (x, y))),
+                    .map(|(k, x, y)| (Scalar::from_repr(&k.into()).unwrap(), (x, y))),
             )
         {
             let res = (generator * &k).to_affine();
diff --git a/k256/src/arithmetic/scalar.rs b/k256/src/arithmetic/scalar.rs
@@ -233,7 +233,7 @@ impl Field for Scalar {
         // TODO: pre-generate several scalars to bring the probability of non-constant-timeness down?
         loop {
             rng.try_fill_bytes(&mut bytes)?;
-            if let Some(scalar) = Scalar::from_repr(bytes).into() {
+            if let Some(scalar) = Scalar::from_repr(&bytes).into() {
                 return Ok(scalar);
             }
         }
@@ -329,8 +329,8 @@ impl PrimeField for Scalar {
     ///
     /// Returns None if the byte array does not contain a big-endian integer in the range
     /// [0, p).
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        let inner = U256::from_be_byte_array(bytes);
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        let inner = U256::from_be_byte_array(*bytes);
         CtOption::new(Self(inner), inner.ct_lt(&Secp256k1::ORDER))
     }
 
@@ -904,7 +904,7 @@ mod tests {
         fn from(x: &BigUint) -> Self {
             debug_assert!(x < &Scalar::modulus_as_biguint());
             let bytes = biguint_to_bytes(x);
-            Self::from_repr(bytes.into()).unwrap()
+            Self::from_repr(&bytes.into()).unwrap()
         }
     }
 
@@ -1221,7 +1221,7 @@ mod tests {
     proptest! {
         #[test]
         fn fuzzy_roundtrip_to_bytes(a in scalar()) {
-            let a_back = Scalar::from_repr(a.to_bytes()).unwrap();
+            let a_back = Scalar::from_repr(&a.to_bytes()).unwrap();
             assert_eq!(a, a_back);
         }
 
diff --git a/p192/src/arithmetic/field.rs b/p192/src/arithmetic/field.rs
@@ -95,8 +95,8 @@ impl PrimeField for FieldElement {
     const DELTA: Self = Self::from_u64(121);
 
     #[inline]
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        Self::from_bytes(&bytes)
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        Self::from_bytes(bytes)
     }
 
     #[inline]
diff --git a/p192/src/arithmetic/scalar.rs b/p192/src/arithmetic/scalar.rs
@@ -178,8 +178,8 @@ impl PrimeField for Scalar {
     const DELTA: Self = Self::from_u64(43046721);
 
     #[inline]
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        Self::from_bytes(&bytes)
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        Self::from_bytes(bytes)
     }
 
     #[inline]
diff --git a/p224/src/arithmetic/field.rs b/p224/src/arithmetic/field.rs
@@ -273,8 +273,8 @@ impl PrimeField for FieldElement {
         Self::from_hex("00000000697b16135c4a62fca5c4f35ea6d5784cf3808e775aad34ec3d046867");
 
     #[inline]
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        Self::from_bytes(&bytes)
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        Self::from_bytes(bytes)
     }
 
     #[inline]
diff --git a/p224/src/arithmetic/scalar.rs b/p224/src/arithmetic/scalar.rs
@@ -173,8 +173,8 @@ impl PrimeField for Scalar {
     const DELTA: Self = Self::from_u64(16);
 
     #[inline]
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        Self::from_bytes(&bytes)
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        Self::from_bytes(bytes)
     }
 
     #[inline]
diff --git a/p256/benches/scalar.rs b/p256/benches/scalar.rs
@@ -8,22 +8,22 @@ use p256::{ProjectivePoint, Scalar, elliptic_curve::group::ff::PrimeField};
 
 fn test_scalar_x() -> Scalar {
     Scalar::from_repr(
-        hex!("519b423d715f8b581f4fa8ee59f4771a5b44c8130b4e3eacca54a56dda72b464").into(),
+        &hex!("519b423d715f8b581f4fa8ee59f4771a5b44c8130b4e3eacca54a56dda72b464").into(),
     )
     .unwrap()
 }
 
 fn test_scalar_y() -> Scalar {
     Scalar::from_repr(
-        hex!("0f56db78ca460b055c500064824bed999a25aaf48ebb519ac201537b85479813").into(),
+        &hex!("0f56db78ca460b055c500064824bed999a25aaf48ebb519ac201537b85479813").into(),
     )
     .unwrap()
 }
 
 fn bench_point_mul<M: Measurement>(group: &mut BenchmarkGroup<'_, M>) {
     let p = ProjectivePoint::GENERATOR;
     let m = test_scalar_x();
-    let s = Scalar::from_repr(m.into()).unwrap();
+    let s = Scalar::from_repr(&m.into()).unwrap();
     group.bench_function("point-scalar mul", |b| b.iter(|| p * s));
 }
 
diff --git a/p256/src/arithmetic/field.rs b/p256/src/arithmetic/field.rs
@@ -179,8 +179,8 @@ impl PrimeField for FieldElement {
     const ROOT_OF_UNITY_INV: Self = Self::ROOT_OF_UNITY.invert_unchecked();
     const DELTA: Self = Self::from_u64(36);
 
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        Self::from_bytes(&bytes)
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        Self::from_bytes(bytes)
     }
 
     fn to_repr(&self) -> FieldBytes {
diff --git a/p256/src/arithmetic/scalar.rs b/p256/src/arithmetic/scalar.rs
@@ -208,7 +208,7 @@ impl Field for Scalar {
         // iterations is vanishingly small.
         loop {
             rng.try_fill_bytes(&mut bytes)?;
-            if let Some(scalar) = Scalar::from_repr(bytes).into() {
+            if let Some(scalar) = Scalar::from_repr(&bytes).into() {
                 return Ok(scalar);
             }
         }
@@ -292,8 +292,8 @@ impl PrimeField for Scalar {
     ///
     /// Returns None if the byte array does not contain a big-endian integer in the range
     /// [0, p).
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        let inner = U256::from_be_byte_array(bytes);
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        let inner = U256::from_be_byte_array(*bytes);
         CtOption::new(Self(inner), inner.ct_lt(&NistP256::ORDER))
     }
 
@@ -736,7 +736,7 @@ mod tests {
         let mut bytes = FieldBytes::default();
         bytes[24..].copy_from_slice(k.to_be_bytes().as_ref());
 
-        let scalar = Scalar::from_repr(bytes).unwrap();
+        let scalar = Scalar::from_repr(&bytes).unwrap();
         assert_eq!(bytes, scalar.to_bytes());
     }
 
diff --git a/p384/benches/scalar.rs b/p384/benches/scalar.rs
@@ -7,21 +7,21 @@ use hex_literal::hex;
 use p384::{ProjectivePoint, Scalar, elliptic_curve::group::ff::PrimeField};
 
 fn test_scalar_x() -> Scalar {
-    Scalar::from_repr(
+    Scalar::from_repr(&
         hex!("201b432d8df14324182d6261db3e4b3f46a8284482d52e370da41e6cbdf45ec2952f5db7ccbce3bc29449f4fb080ac97").into()
     ).unwrap()
 }
 
 fn test_scalar_y() -> Scalar {
-    Scalar::from_repr(
+    Scalar::from_repr(&
         hex!("23d9f4ea6d87b7d6163d64256e3449255db14786401a51daa7847161bf56d494325ad2ac8ba928394e01061d882c3528").into()
     ).unwrap()
 }
 
 fn bench_point_mul<M: Measurement>(group: &mut BenchmarkGroup<'_, M>) {
     let p = ProjectivePoint::GENERATOR;
     let m = test_scalar_x();
-    let s = Scalar::from_repr(m.into()).unwrap();
+    let s = Scalar::from_repr(&m.into()).unwrap();
     group.bench_function("point-scalar mul", |b| b.iter(|| p * s));
 }
 
diff --git a/p384/src/arithmetic/field.rs b/p384/src/arithmetic/field.rs
@@ -121,8 +121,8 @@ impl PrimeField for FieldElement {
     const DELTA: Self = Self::from_u64(49);
 
     #[inline]
-    fn from_repr(bytes: FieldBytes) -> CtOption<Self> {
-        Self::from_bytes(&bytes)
+    fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {
+        Self::from_bytes(bytes)
     }
 
     #[inline]
diff --git a/p384/src/arithmetic/scalar.rs b/p384/src/arithmetic/scalar.rs
diff --git a/p521/benches/scalar.rs b/p521/benches/scalar.rs
diff --git a/p521/src/arithmetic/field.rs b/p521/src/arithmetic/field.rs
diff --git a/p521/src/arithmetic/scalar.rs b/p521/src/arithmetic/scalar.rs
diff --git a/primeorder/src/affine.rs b/primeorder/src/affine.rs
diff --git a/primeorder/src/dev.rs b/primeorder/src/dev.rs
diff --git a/sm2/src/arithmetic/field.rs b/sm2/src/arithmetic/field.rs
diff --git a/sm2/src/arithmetic/scalar.rs b/sm2/src/arithmetic/scalar.rs
diff --git a/sm2/src/dsa/signing.rs b/sm2/src/dsa/signing.rs

Original file line number	Diff line number	Diff line change
`@@ -8,22 +8,22 @@ use hex_literal::hex;`
`8`	`8`
`9`	`9`	`fn test_scalar_x() -> Scalar {`
`10`	`10`	`Scalar::from_repr(`
`11`		`- hex!("519b423d715f8b581f4fa8ee59f4771a5b44c8130b4e3eacca54a56dda72b464").into(),`
	`11`	`+ &hex!("519b423d715f8b581f4fa8ee59f4771a5b44c8130b4e3eacca54a56dda72b464").into(),`
`12`	`12`	`)`
`13`	`13`	`.unwrap()`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`fn test_scalar_y() -> Scalar {`
`17`	`17`	`Scalar::from_repr(`
`18`		`- hex!("0f56db78ca460b055c500064824bed999a25aaf48ebb519ac201537b85479813").into(),`
	`18`	`+ &hex!("0f56db78ca460b055c500064824bed999a25aaf48ebb519ac201537b85479813").into(),`
`19`	`19`	`)`
`20`	`20`	`.unwrap()`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`fn bench_point_mul<M: Measurement>(group: &mut BenchmarkGroup<M>) {`
`24`	`24`	`let p = ProjectivePoint::GENERATOR;`
`25`	`25`	`let m = test_scalar_x();`
`26`		`- let s = Scalar::from_repr(m.into()).unwrap();`
	`26`	`+ let s = Scalar::from_repr(&m.into()).unwrap();`
`27`	`27`	`group.bench_function("point-scalar mul", \|b\| b.iter(\|\| p * s));`
`28`	`28`	`}`
`29`	`29`
Original file line number	Diff line number	Diff line change
`@@ -94,8 +94,8 @@ impl PrimeField for FieldElement {`
`94`	`94`	`type Repr = FieldBytes;`
`95`	`95`
`96`	`96`	`#[inline]`
`97`		`- fn from_repr(bytes: FieldBytes) -> CtOption<Self> {`
`98`		`- Self::from_bytes(&bytes)`
	`97`	`+ fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {`
	`98`	`+ Self::from_bytes(bytes)`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`#[inline]`
Original file line number	Diff line number	Diff line change
`@@ -130,8 +130,8 @@ impl IsHigh for Scalar {`
`130`	`130`	`impl PrimeField for Scalar {`
`131`	`131`	`type Repr = FieldBytes;`
`132`	`132`
`133`		`- fn from_repr(repr: Self::Repr) -> CtOption<Self> {`
`134`		`- Self::from_bytes(&repr)`
	`133`	`+ fn from_repr(repr: &Self::Repr) -> CtOption<Self> {`
	`134`	`+ Self::from_bytes(repr)`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`fn to_repr(&self) -> Self::Repr {`
Original file line number	Diff line number	Diff line change
`@@ -90,8 +90,8 @@ impl PrimeField for FieldElement {`
`90`	`90`	`const DELTA: Self = Self::from_u64(121);`
`91`	`91`
`92`	`92`	`#[inline]`
`93`		`- fn from_repr(bytes: FieldBytes) -> CtOption<Self> {`
`94`		`- Self::from_bytes(&bytes)`
	`93`	`+ fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {`
	`94`	`+ Self::from_bytes(bytes)`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`#[inline]`
Original file line number	Diff line number	Diff line change
`@@ -116,8 +116,8 @@ impl PrimeField for Scalar {`
`116`	`116`	`const DELTA: Self = Self::from_u64(9);`
`117`	`117`
`118`	`118`	`#[inline]`
`119`		`- fn from_repr(bytes: FieldBytes) -> CtOption<Self> {`
`120`		`- Self::from_bytes(&bytes)`
	`119`	`+ fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {`
	`120`	`+ Self::from_bytes(bytes)`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`#[inline]`
Original file line number	Diff line number	Diff line change
`@@ -93,8 +93,8 @@ impl PrimeField for FieldElement {`
`93`	`93`	`const DELTA: Self = Self::from_u64(9);`
`94`	`94`
`95`	`95`	`#[inline]`
`96`		`- fn from_repr(bytes: FieldBytes) -> CtOption<Self> {`
`97`		`- Self::from_bytes(&bytes)`
	`96`	`+ fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {`
	`97`	`+ Self::from_bytes(bytes)`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`#[inline]`
Original file line number	Diff line number	Diff line change
`@@ -124,8 +124,8 @@ impl PrimeField for Scalar {`
`124`	`124`	`const DELTA: Self = Self::from_u64(16);`
`125`	`125`
`126`	`126`	`#[inline]`
`127`		`- fn from_repr(bytes: FieldBytes) -> CtOption<Self> {`
`128`		`- Self::from_bytes(&bytes)`
	`127`	`+ fn from_repr(bytes: &FieldBytes) -> CtOption<Self> {`
	`128`	`+ Self::from_bytes(bytes)`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`#[inline]`