Skip to content

Commit 75619f2

Browse files
Hsiu Che YuDanilo Krummrich
authored andcommitted
rust: alloc: fix assert in Vec::reserve doc test
The assert in the doctest used `>= 10`, which only checks that the capacity can hold `additional` elements, ignoring the existing length of `v`. The correct check should ensure there is room for `additional` *extra* elements on top of what is already in the vector. Fix the assert to use `>= v.len() + 10` so the example accurately reflects the actual semantics of the function. Reported-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> Closes: https://lore.kernel.org/rust-for-linux/CANiq72nkXWhjK9iFRrhGtkMZGsvNE_zVsu4JnxaFRfxWL7RRdg@mail.gmail.com/ Fixes: 2aac4cd ("rust: alloc: implement kernel `Vec` type") Signed-off-by: Hsiu Che Yu <yu.whisper.personal@gmail.com> Reviewed-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> Link: https://patch.msgid.link/20260427-doctest-kvec-reserve-v1-1-0623abcd9c2e@gmail.com Signed-off-by: Danilo Krummrich <dakr@kernel.org>
1 parent 254f496 commit 75619f2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎rust/kernel/alloc/kvec.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ where
614614
///
615615
/// v.reserve(10, GFP_KERNEL)?;
616616
/// let cap = v.capacity();
617-
/// assert!(cap >= 10);
617+
/// assert!(cap >= v.len() + 10);
618618
///
619619
/// v.reserve(10, GFP_KERNEL)?;
620620
/// let new_cap = v.capacity();

0 commit comments

Comments
 (0)