gccrs: make invalid inner attributes show error

gcc/rust/ChangeLog:

	* ast/rust-ast.cc (Attribute::is_derive):
	Change is_derive method with its valid path.
	* util/rust-attribute-values.h:
	Delete redudant derive attribute.
	* util/rust-attributes.cc (AttributeChecker::check_inner_attribute):
	Give can_be_inner a value for each atribute.
	(AttributeChecker::check_inner_attributes):
	Implement method for errors check.
	* util/rust-attributes.h (struct BuiltinAttrDefinition):
	Add can_be_inner object in struct.

gcc/testsuite/ChangeLog:

	* rust/compile/issue-4212.rs:

Signed-off-by: Lucas Ly Ba <[email protected]>

Author: Lucas Ly Ba

gcc/rust/ast/rust-ast.cc

@@ -248,7 +248,7 @@ Attribute::as_string () const
 bool
 Attribute::is_derive () const
 {
-  return has_attr_input () && get_path () == Values::Attributes::DERIVE;
+  return has_attr_input () && get_path () == Values::Attributes::DERIVE_ATTR;
 }
 
 /**

gcc/rust/util/rust-attribute-values.h

@@ -49,8 +49,6 @@ class Attributes
   static constexpr auto &PROC_MACRO_DERIVE = "proc_macro_derive";
   static constexpr auto &PROC_MACRO_ATTRIBUTE = "proc_macro_attribute";
 
-  static constexpr auto &DERIVE = "derive";
-
   static constexpr auto &TARGET_FEATURE = "target_feature";
   // From now on, these are reserved by the compiler and gated through
   // #![feature(rustc_attrs)]

gcc/rust/util/rust-attributes.cc

@@ -67,69 +67,60 @@ using Attrs = Values::Attributes;
 
 // https://doc.rust-lang.org/stable/nightly-rustc/src/rustc_feature/builtin_attrs.rs.html#248
 static const BuiltinAttrDefinition __definitions[]
-  = {{Attrs::INLINE, CODE_GENERATION},
-     {Attrs::COLD, CODE_GENERATION},
-     {Attrs::CFG, EXPANSION},
-     {Attrs::CFG_ATTR, EXPANSION},
-     {Attrs::DERIVE_ATTR, EXPANSION},
-     {Attrs::DEPRECATED, STATIC_ANALYSIS},
-     {Attrs::ALLOW, STATIC_ANALYSIS},
-     {Attrs::ALLOW_INTERNAL_UNSTABLE, STATIC_ANALYSIS},
-     {Attrs::DOC, HIR_LOWERING},
-     {Attrs::MUST_USE, STATIC_ANALYSIS},
-     {Attrs::LANG, HIR_LOWERING},
-     {Attrs::LINK_NAME, CODE_GENERATION},
-     {Attrs::LINK_SECTION, CODE_GENERATION},
-     {Attrs::NO_MANGLE, CODE_GENERATION},
-     {Attrs::REPR, CODE_GENERATION},
-     {Attrs::RUSTC_BUILTIN_MACRO, EXPANSION},
-     {Attrs::RUSTC_MACRO_TRANSPARENCY, EXPANSION},
-     {Attrs::PATH, EXPANSION},
-     {Attrs::MACRO_USE, NAME_RESOLUTION},
-     {Attrs::MACRO_EXPORT, NAME_RESOLUTION},
-     {Attrs::PROC_MACRO, EXPANSION},
-     {Attrs::PROC_MACRO_DERIVE, EXPANSION},
-     {Attrs::PROC_MACRO_ATTRIBUTE, EXPANSION},
-
-     {Attrs::DERIVE, EXPANSION},
+  = {{Attrs::INLINE, CODE_GENERATION, false},
+     {Attrs::COLD, CODE_GENERATION, true},
+     {Attrs::CFG, EXPANSION, true},
+     {Attrs::CFG_ATTR, EXPANSION, true},
+     {Attrs::DERIVE_ATTR, EXPANSION, false},
+     {Attrs::DEPRECATED, STATIC_ANALYSIS, true},
+     {Attrs::ALLOW, STATIC_ANALYSIS, true},
+     {Attrs::ALLOW_INTERNAL_UNSTABLE, STATIC_ANALYSIS, false},
+     {Attrs::DOC, HIR_LOWERING, true},
+     {Attrs::MUST_USE, STATIC_ANALYSIS, true},
+     {Attrs::LANG, HIR_LOWERING, false},
+     {Attrs::LINK_NAME, CODE_GENERATION, true},
+     {Attrs::LINK_SECTION, CODE_GENERATION, true},
+     {Attrs::NO_MANGLE, CODE_GENERATION, true},
+     {Attrs::REPR, CODE_GENERATION, false},
+     {Attrs::RUSTC_BUILTIN_MACRO, EXPANSION, true},
+     {Attrs::RUSTC_MACRO_TRANSPARENCY, EXPANSION, true},
+     {Attrs::PATH, EXPANSION, false},
+     {Attrs::MACRO_USE, NAME_RESOLUTION, true},
+     {Attrs::MACRO_EXPORT, NAME_RESOLUTION, true},
+     {Attrs::PROC_MACRO, EXPANSION, true},
+     {Attrs::PROC_MACRO_DERIVE, EXPANSION, true},
+     {Attrs::PROC_MACRO_ATTRIBUTE, EXPANSION, true},
      // FIXME: This is not implemented yet, see
      // https://github.com/Rust-GCC/gccrs/issues/1475
-     {Attrs::TARGET_FEATURE, CODE_GENERATION},
+     {Attrs::TARGET_FEATURE, CODE_GENERATION, false},
      // From now on, these are reserved by the compiler and gated through
      // #![feature(rustc_attrs)]
-     {Attrs::RUSTC_DEPRECATED, STATIC_ANALYSIS},
-     {Attrs::RUSTC_INHERIT_OVERFLOW_CHECKS, CODE_GENERATION},
-     {Attrs::STABLE, STATIC_ANALYSIS},
-     {Attrs::UNSTABLE, STATIC_ANALYSIS},
-
+     {Attrs::RUSTC_DEPRECATED, STATIC_ANALYSIS, true},
+     {Attrs::RUSTC_INHERIT_OVERFLOW_CHECKS, CODE_GENERATION, true},
+     {Attrs::STABLE, STATIC_ANALYSIS, true},
+     {Attrs::UNSTABLE, STATIC_ANALYSIS, true},
      // assuming we keep these for static analysis
-     {Attrs::RUSTC_PROMOTABLE, CODE_GENERATION},
-     {Attrs::RUSTC_CONST_STABLE, STATIC_ANALYSIS},
-     {Attrs::RUSTC_CONST_UNSTABLE, STATIC_ANALYSIS},
-     {Attrs::RUSTC_ALLOW_CONST_FN_UNSTABLE, STATIC_ANALYSIS},
-     {Attrs::PRELUDE_IMPORT, NAME_RESOLUTION},
-     {Attrs::TRACK_CALLER, CODE_GENERATION},
-     {Attrs::RUSTC_SPECIALIZATION_TRAIT, TYPE_CHECK},
-     {Attrs::RUSTC_UNSAFE_SPECIALIZATION_MARKER, TYPE_CHECK},
-     {Attrs::RUSTC_RESERVATION_IMPL, TYPE_CHECK},
-     {Attrs::RUSTC_PAREN_SUGAR, TYPE_CHECK},
-     {Attrs::RUSTC_NONNULL_OPTIMIZATION_GUARANTEED, TYPE_CHECK},
-
-     {Attrs::RUSTC_LAYOUT_SCALAR_VALID_RANGE_START, CODE_GENERATION},
-
+     {Attrs::RUSTC_PROMOTABLE, CODE_GENERATION, true},
+     {Attrs::RUSTC_CONST_STABLE, STATIC_ANALYSIS, true},
+     {Attrs::RUSTC_CONST_UNSTABLE, STATIC_ANALYSIS, true},
+     {Attrs::RUSTC_ALLOW_CONST_FN_UNSTABLE, STATIC_ANALYSIS, true},
+     {Attrs::PRELUDE_IMPORT, NAME_RESOLUTION, true},
+     {Attrs::TRACK_CALLER, CODE_GENERATION, true},
+     {Attrs::RUSTC_SPECIALIZATION_TRAIT, TYPE_CHECK, true},
+     {Attrs::RUSTC_UNSAFE_SPECIALIZATION_MARKER, TYPE_CHECK, true},
+     {Attrs::RUSTC_RESERVATION_IMPL, TYPE_CHECK, true},
+     {Attrs::RUSTC_PAREN_SUGAR, TYPE_CHECK, true},
+     {Attrs::RUSTC_NONNULL_OPTIMIZATION_GUARANTEED, TYPE_CHECK, true},
+     {Attrs::RUSTC_LAYOUT_SCALAR_VALID_RANGE_START, CODE_GENERATION, true},
      // TODO: be careful about calling functions marked with this?
-     {Attrs::RUSTC_ARGS_REQUIRED_CONST, CODE_GENERATION},
-
-     {Attrs::PRELUDE_IMPORT, NAME_RESOLUTION},
-
-     {Attrs::RUSTC_DIAGNOSTIC_ITEM, STATIC_ANALYSIS},
-     {Attrs::RUSTC_ON_UNIMPLEMENTED, STATIC_ANALYSIS},
-
-     {Attrs::FUNDAMENTAL, TYPE_CHECK},
-     {Attrs::NON_EXHAUSTIVE, TYPE_CHECK},
-     {Attrs::RUSTFMT, EXTERNAL},
-
-     {Attrs::TEST, CODE_GENERATION}};
+     {Attrs::RUSTC_ARGS_REQUIRED_CONST, CODE_GENERATION, true},
+     {Attrs::PRELUDE_IMPORT, NAME_RESOLUTION, true},
+     {Attrs::RUSTC_DIAGNOSTIC_ITEM, STATIC_ANALYSIS, true},
+     {Attrs::RUSTC_ON_UNIMPLEMENTED, STATIC_ANALYSIS, true},
+     {Attrs::FUNDAMENTAL, TYPE_CHECK, true},
+     {Attrs::NON_EXHAUSTIVE, TYPE_CHECK, true},
+     {Attrs::RUSTFMT, EXTERNAL, true},
+     {Attrs::TEST, CODE_GENERATION, false}};
 
 BuiltinAttributeMappings *
 BuiltinAttributeMappings::get ()
@@ -326,6 +317,26 @@ check_proc_macro_non_root (AST::AttrVec attributes, location_t loc)
     }
 }
 
+void
+AttributeChecker::check_inner_attribute (const AST::Attribute &attribute)
+{
+  BuiltinAttrDefinition result;
+
+  if (!is_builtin (attribute, result))
+    return;
+
+  if (!result.can_be_inner)
+    rust_error_at (attribute.get_locus (),
+		   "attribute cannot be used at crate level");
+}
+
+void
+AttributeChecker::check_inner_attributes (const AST::AttrVec &attributes)
+{
+  for (auto &attr : attributes)
+    check_inner_attribute (attr);
+}
+
 void
 AttributeChecker::check_attribute (const AST::Attribute &attribute)
 {
@@ -356,15 +367,6 @@ AttributeChecker::check_attribute (const AST::Attribute &attribute)
     check_doc_attribute (attribute);
 }
 
-void
-AttributeChecker::check_inner_attributes (const AST::AttrVec &attributes)
-{
-  for (auto &attr : attributes)
-    if (attr.is_derive ())
-      rust_error_at (attr.get_locus (),
-		     "derive attribute cannot be used at crate level");
-}
-
 void
 AttributeChecker::check_attributes (const AST::AttrVec &attributes)
 {

gcc/rust/util/rust-attributes.h

@@ -54,10 +54,11 @@ struct BuiltinAttrDefinition
 {
   std::string name;
   CompilerPass handler;
+  bool can_be_inner;
 
   static BuiltinAttrDefinition get_error ()
   {
-    return BuiltinAttrDefinition{"", UNKNOWN};
+    return BuiltinAttrDefinition{"", UNKNOWN, false};
   }
 
   static BuiltinAttrDefinition &error_node ()
@@ -102,12 +103,14 @@ class AttributeChecker : public AST::DefaultASTVisitor
 
 private:
   using AST::DefaultASTVisitor::visit;
+
+  /* Check the validity of an inner attribute */
+  void check_inner_attribute (const AST::Attribute &attribute);
+  /* Check the validy of all inner attributes */
+  void check_inner_attributes (const AST::AttrVec &attributes);
   /* Check the validity of a given attribute */
   void check_attribute (const AST::Attribute &attribute);
-
   /* Check the validity of all given attributes */
-
-  void check_inner_attributes (const AST::AttrVec &attributes);
   void check_attributes (const AST::AttrVec &attributes);
 
   // rust-ast.h

gcc/testsuite/rust/compile/issue-4212.rs

@@ -1,5 +1,5 @@
 #![derive(PartialOrd, PartialEq)]
-// { dg-error "derive attribute cannot be used at crate level" "" { target *-*-* } .-1 }
+// { dg-error "attribute cannot be used at crate level" "" { target *-*-* } .-1 }
 pub fn check_ge(a: i32, b: i32) -> bool {
     a >= b
 }