You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lots of APIs are using overloading. (ex: Unified#use and Unified#data) I think overloading is quite harmful. To use this, we need to implement lots of assertion code and those assertions seem to be quite fragile.
I'm going to split those APIs
2 types of Parser and Compiler
A function or a class can be Parser or Compiler. To make this possible, we have to use another fragile assertion, checking the parser or the compiler is a function or not.
I think it should be better to use a class for all times.
data property in Unified
I think data is quite useless. To share the options, we can provide them to each plugin.
The text was updated successfully, but these errors were encountered:
To create a typing for a Node with props, using type NodeWithProps<P> = Node & P is considered fragile.
Just like React component, it should be better to provide a dedicated property, props, to use custom fields.
Overloading
Lots of APIs are using overloading. (ex:
Unified#use
andUnified#data
) I think overloading is quite harmful. To use this, we need to implement lots of assertion code and those assertions seem to be quite fragile.I'm going to split those APIs
2 types of Parser and Compiler
A function or a class can be Parser or Compiler. To make this possible, we have to use another fragile assertion, checking the parser or the compiler is a function or not.
I think it should be better to use a class for all times.
data
property in UnifiedI think
data
is quite useless. To share the options, we can provide them to each plugin.The text was updated successfully, but these errors were encountered: