Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add the Coriolis Acceleration #796

Open
kevin-alcaniz opened this issue Mar 25, 2025 · 5 comments · May be fixed by #799
Open

ENH: Add the Coriolis Acceleration #796

kevin-alcaniz opened this issue Mar 25, 2025 · 5 comments · May be fixed by #799
Labels
Aerodynamics Any problem to be worked on top of RocketPy's Aerodynamic Enhancement New feature or request, including adjustments in current codes

Comments

@kevin-alcaniz
Copy link
Collaborator

I noticed that RocketPy currently doesn’t account for Coriolis effects in its equations.

I made a few local modifications to include this behavior and found that, for a rocket with a 3 km apogee, the deviation at the impact point is less than 10 meters.

Since these changes were minimal, I thought you might be interested in checking them out.

Let me know if you're interested!

@Gui-FernandesBR
Copy link
Member

@kevin-alcaniz great.
Yes, please do share with us the implementation you are proposing, and also let us check with you the deviations you've mentioned

@Gui-FernandesBR Gui-FernandesBR added Enhancement New feature or request, including adjustments in current codes Aerodynamics Any problem to be worked on top of RocketPy's Aerodynamic labels Mar 25, 2025
@kevin-alcaniz
Copy link
Collaborator Author

Do I make a pull request??

@Gui-FernandesBR
Copy link
Member

Do I make a pull request??

Yes, please! Let it clear that your code is a code suggestion and we will discuss it thoroughly.

Kevin, I added you as an external collaborator to this repo, this should make it possible for you to create new branches on this repository directly (rather than on your own fork). If you agree, I'd recommend you to start opening branches on this repo directly, whenever you desire to pull request new changes. This would make the review process easier, given that the whole organization will have easier access to your branch.

In case you still want to keep pulling from your fork onto our develop branch, that's ok as well.

@kevin-alcaniz
Copy link
Collaborator Author

Great!! I'm going to create the branch

@kevin-alcaniz
Copy link
Collaborator Author

I've already uploaded my local branch to the repo. I'll submit the PR later, as I want to include a brief theoretical explanation to justify the changes. In the meantime, you can check it out!

@Gui-FernandesBR Gui-FernandesBR linked a pull request Apr 3, 2025 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aerodynamics Any problem to be worked on top of RocketPy's Aerodynamic Enhancement New feature or request, including adjustments in current codes
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants