-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add the Coriolis Acceleration #796
Comments
@kevin-alcaniz great. |
Do I make a pull request?? |
Yes, please! Let it clear that your code is a code suggestion and we will discuss it thoroughly. Kevin, I added you as an external collaborator to this repo, this should make it possible for you to create new branches on this repository directly (rather than on your own fork). If you agree, I'd recommend you to start opening branches on this repo directly, whenever you desire to pull request new changes. This would make the review process easier, given that the whole organization will have easier access to your branch. In case you still want to keep pulling from your fork onto our develop branch, that's ok as well. |
Great!! I'm going to create the branch |
I've already uploaded my local branch to the repo. I'll submit the PR later, as I want to include a brief theoretical explanation to justify the changes. In the meantime, you can check it out! |
I noticed that RocketPy currently doesn’t account for Coriolis effects in its equations.
I made a few local modifications to include this behavior and found that, for a rocket with a 3 km apogee, the deviation at the impact point is less than 10 meters.
Since these changes were minimal, I thought you might be interested in checking them out.
Let me know if you're interested!
The text was updated successfully, but these errors were encountered: