Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Extend Rocket.Chat Auth for Google Auth to support Github Auth #185

Open
Sing-Li opened this issue Oct 6, 2022 · 2 comments
Open

Comments

@Sing-Li
Copy link
Member

Sing-Li commented Oct 6, 2022

Using the existing "Rocket.Chat Auth for Google Auth Component" as a framework, add support for the following Rocket.Chat auths:

  • Github
  • Simple email

The existing component should be extended, instead of new components created -- since they're all Rocket.Chat auths.

(it may be a good idea to keep each supported auth as a sub-component/plugin of the auth - hence using it as a framework)

@Nabhag8848
Copy link

Hey @Sing-Li, i would like to work on this issue can you assign it to me. I will start right away😄

@Dnouv
Copy link
Member

Dnouv commented Jan 5, 2023

Hey @Nabhag8848

Thank you for taking up the issue. However, you would have to implement this in RC4Conferences first and then backport it to RC4Community; RC4Conferences can be considered as a beta testing ground for the new components.
And please do explain the approach you will be taking for this issue on RocketChat/RC4Conferences#42 this can in a way be good for refining your solution by the community.

If you have any doubts, please feel free to ask them right away. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants