Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ISM43340 configuration up one level #82

Open
JNeiger opened this issue Aug 2, 2019 · 0 comments
Open

Move ISM43340 configuration up one level #82

JNeiger opened this issue Aug 2, 2019 · 0 comments

Comments

@JNeiger
Copy link
Contributor

JNeiger commented Aug 2, 2019

All the driver configuration should actually be outside the driver itself. This may force another layer of abstraction, but I think it's worth it to keep things clean and allow very easy implementation for future radio swaps.

The configuration code and the while loop that is currently in RadioModule should be pushed down into the WifiRadio class.

RadioModule -> RadioLink -> WifiRadio -> ISM43340

RadioModule just sends the raw micro packets.
RadioLink packs into the rtp packet
WifiRadio sets up the ISM43340 and does all the specific radio stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant