Add cross-contract guard for revenue_deposit_contract callable-only-by-offering allowlist

[thlpkee20-wq]

Description

revenue_deposit_contract.rs accepts deposit calls from any caller. Add an allowlist of authorized offering contract addresses and reject deposits from unauthorized callers with UnauthorizedDepositor.

Requirements and context

• Must be secure, tested, and documented
• Should be efficient and easy to review
• Relevant code: Revora-Contracts/src/revenue_deposit_contract.rs
• Allowlist managed by deposit-contract admin with two-step rotation

Suggested execution

• Fork the repo and create a branch
• git checkout -b feat/deposit-contract-allowlist
• Implement changes
  • Add authorized_offerings: Vec<Address> storage
  • Gate deposit on caller-in-set and require_auth(caller)
  • Emit dep_allow_add, dep_allow_rm events
• Validate security and correctness assumptions

Test and commit

• Run tests
  • cargo test --all
• Cover edge cases
  • Empty allowlist must reject all deposits, not default-open
• Include test output and security notes

Example commit message

feat: gate revenue_deposit_contract.deposit on offering allowlist

Guidelines

• Minimum 95 percent test coverage
• Clear documentation
• Timeframe: 96 hours

[Danielodingz]

@Danielodingz has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hey maintainer, please i would like to work on this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Danielodingz to this issue.

[Hunter-baddie]

@Hunter-baddie has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Please can I be assigned this issue to work on?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Hunter-baddie to this issue.

[bbjiggy]

@bbjiggy has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hi, I'd like to work on this issue.

My approach would be to introduce a persistent authorized_offerings allowlist managed by the deposit contract admin through a secure two-step rotation process. I'll update the deposit flow to require both require_auth(caller) and membership in the allowlist, returning UnauthorizedDepositor for unauthorized callers. I'll emit dep_allow_add and dep_allow_rm events for all allowlist changes to improve on-chain observability. I'll also ensure an empty allowlist defaults to rejecting all deposits rather than permitting them. Finally, I'll add comprehensive tests covering authorized and unauthorized deposits, allowlist rotation, event emission, empty-allowlist behavior, and edge cases, then run cargo test --all and document the security assumptions and implementation details for an easy review.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @bbjiggy to this issue.

[grantfox-oss]

🦊 GrantFox — @Danielodingz has been assigned to this issue!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #481)
2. Your PR will be reviewed by the RevoraOrg maintainers

Good luck! Track your progress on GrantFox.

[drips-wave]

Congratulations, @Danielodingz! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.

🧑‍💻 @Danielodingz: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox!

@Danielodingz's PR #508 was approved and merged by @thlpkee20-wq.

🏆 @Danielodingz: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (261 total points). Track your full progress on GrantFox.

👏 Great work, @Danielodingz! Keep contributing to RevoraOrg.