Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android app crashes when paywall is triggered #1127

Open
5 tasks done
khlling opened this issue Nov 10, 2024 · 5 comments · May be fixed by #1186
Open
5 tasks done

Android app crashes when paywall is triggered #1127

khlling opened this issue Nov 10, 2024 · 5 comments · May be fixed by #1186
Labels
bug Something isn't working

Comments

@khlling
Copy link

khlling commented Nov 10, 2024 •
edited
Loading

Describe the bug
Android crashes when a paywall is triggered. I was using V8.2.6

    "react-native-purchases": "8.2.6",
    "react-native-purchases-ui": "8.2.6",

However, I had to downgrade to v7.28.1 and the paywall appears as expected

    "react-native-purchases": "7.28.1",
    "react-native-purchases-ui": "7.28.1",

My code:

import RevenueCatUI, { PAYWALL_RESULT } from "react-native-purchases-ui";

async function presentPaywall(): Promise<boolean> {
    // Present paywall for current offering:
    const paywallResult: PAYWALL_RESULT = await RevenueCatUI.presentPaywall();
    // or if you need to present a specific offering:
    const paywallResult: PAYWALL_RESULT = await RevenueCatUI.presentPaywall({
        offering: offering // Optional Offering object obtained through getOfferings
    });

    switch (paywallResult) {
        case PAYWALL_RESULT.NOT_PRESENTED:
        case PAYWALL_RESULT.ERROR:
        case PAYWALL_RESULT.CANCELLED:
            return false;
        case PAYWALL_RESULT.PURCHASED:
        case PAYWALL_RESULT.RESTORED:
            return true;
        default:
            return false;
    }
}

async function presentPaywallIfNeeded() {
    // Present paywall for current offering:
    const paywallResult: PAYWALL_RESULT = await RevenueCatUI.presentPaywallIfNeeded({
        requiredEntitlementIdentifier: "pro"
    });
    // If you need to present a specific offering:
    const paywallResult: PAYWALL_RESULT = await RevenueCatUI.presentPaywallIfNeeded({
        offering: offering, // Optional Offering object obtained through getOfferings
        requiredEntitlementIdentifier: "pro"
    });
}
  1. Environment
    1. Platform: Android
    2. SDK version: 34
    3. OS version: 14
    4. Xcode/Android Studio version:
    5. React Native version: 0.74.6
    6. SDK installation (CocoaPods + version or manual):
    7. How widespread is the issue. Percentage of devices affected. - All Android devices
  2. Debug logs that reproduce the issue
  3. Steps to reproduce, with a description of expected vs. actual behavior
  4. Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)
androidx.compose.ui.platform.AndroidComposeView.<init> (AndroidComposeView.android.kt:218)
androidx.compose.ui.platform.Wrapper_androidKt.setContent (Wrapper.android.kt:77)
androidx.compose.ui.platform.AbstractComposeView.ensureCompositionCreated (ComposeView.android.kt:251)
androidx.compose.ui.platform.AbstractComposeView.onAttachedToWindow (ComposeView.android.kt:283)
android.view.View.dispatchAttachedToWindow (View.java:22662)
android.view.ViewGroup.dispatchAttachedToWindow (ViewGroup.java:3495)
android.view.ViewGroup.dispatchAttachedToWindow (ViewGroup.java:3502)
android.view.ViewGroup.dispatchAttachedToWindow (ViewGroup.java:3502)
android.view.ViewGroup.dispatchAttachedToWindow (ViewGroup.java:3502)
android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:3274)
android.view.ViewRootImpl.doTraversal (ViewRootImpl.java:2741)
android.view.ViewRootImpl$TraversalRunnable.run (ViewRootImpl.java:9960)
android.view.Choreographer$CallbackRecord.run (Choreographer.java:1406)
android.view.Choreographer$CallbackRecord.run (Choreographer.java:1415)
android.view.Choreographer.doCallbacks (Choreographer.java:1015)
android.view.Choreographer.doFrame (Choreographer.java:945)
android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:1389)
android.os.Handler.handleCallback (Handler.java:959)
android.os.Handler.dispatchMessage (Handler.java:100)
android.os.Looper.loopOnce (Looper.java:232)
android.os.Looper.loop (Looper.java:317)
android.app.ActivityThread.main (ActivityThread.java:8592)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:580)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:878)

Additional context
@khlling khlling added the bug Something isn't working label Nov 10, 2024
@RCGitBot
Copy link
Contributor

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

@Xyanam
Copy link

Xyanam commented Nov 26, 2024

up

@fendermany
Copy link

fendermany commented Jan 15, 2025 •
edited
Loading

RevenueCatUI.Paywall doesn't work on 7.28.1 either

@Tim-Pet
Copy link

Tim-Pet commented Feb 7, 2025

any updates on this?

NosimusAI added a commit to NosimusAI/react-native-purchases that referenced this issue Feb 22, 2025
@NosimusAI
fix: add FragmentActivity check and error handling in RNPaywallsModule (
57d14fb 
fixes RevenueCat#1127)
@NosimusAI NosimusAI linked a pull request Feb 22, 2025 that will close this issue
Open
3 tasks
@cfogelklou
Copy link

cfogelklou commented Mar 16, 2025 •
edited
Loading

So, it seems that only v2 supports react-native's "new architecture." Any of us who have bumped RN version and also enabled new architecture also need to bump to v2 of purchases-ui. https://www.revenuecat.com/docs/tools/paywalls-v2#:~:text=Paywalls%20v2%20is%20currently%20in%20beta%2C%20and%20has,new%20editor.%20Not%20supported%20on%20watchOS%2C%20or%20visionOS.

With version 8.8.1:

> Task :react-native-purchases-ui:generateCodegenSchemaFromJavaScript
No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add FragmentActivity check in RNPaywallsModule (fixes #1127) NosimusAI/react-native-purchases
6 participants
@khlling @cfogelklou @fendermany @RCGitBot @Tim-Pet @Xyanam