[Paywalls V2] Add visible property to all components (and overrides to ones that were missing)
#4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build increased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 61.0 kB |
| RevenueCatUI.TabsComponentViewModel.TabsComponentViewModel | ⬆️ 13.8 kB |
| RevenueCatUI.TimelineComponentViewModel.TimelineComponentViewMode... | ⬆️ 10.1 kB |
| 📝 RevenueCat.PaywallComponent.PartialTimelineComponent.PartialTimel... | ⬆️ 4.6 kB |
| RevenueCatUI.TextComponentViewModel.TextComponentViewModel | ⬇️ -4.3 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
tonidero
reviewed
Feb 13, 2025
RevenueCatUI/Templates/V2/Components/Image/ImageComponentView.swift
Outdated
Show resolved
Hide resolved
RevenueCatUI/Templates/V2/Components/Timeline/TimelineComponentView.swift
Outdated
Show resolved
Hide resolved
joshdholtz
force-pushed
the
paywalls-v2/visible-property
branch
from
29bb1dd to
35d9e2f
Compare
ajpallares
reviewed
Feb 13, 2025
joshdholtz
force-pushed
the
paywalls-v2/visible-property
branch
from
f8286e8 to
5bc8084
Compare
joshdholtz
changed the title
visible property to all components (and overrides to ones that were missing)visible property to all components (and overrides to ones that were missing)
JayShortway
approved these changes
Feb 14, 2025
|
|
||
| public enum PaywallComponent: PaywallComponentBase { |
There was a problem hiding this comment.
I'm curious about the motivation behind this change. (I have no opinion on it though haha.)
There was a problem hiding this comment.
Ahhhh... at one point I had the PaywallComponentBase protocol required a visible property but then took it away 😅
This could use some clean up work in the future anyway 🤷♂️
There was a problem hiding this comment.
Haha okay okay, thanks for explaining!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
All (or almost all) need the new
visiblepropertyDescription
Coming soon