fix(respect): retryAfter should be in seconds (#2267)

Author: DmitryAnansky

.changeset/wild-jeans-bake.md

@@ -0,0 +1,6 @@
+---
+"@redocly/respect-core": patch
+"@redocly/cli": patch
+---
+
+Updated the `retryAfter` property in Respect to use seconds (instead of milliseconds) for consistency with the Arazzo specification.

__tests__/respect/reusable-components/reusable-components.arazzo.yaml

@@ -137,7 +137,7 @@ components:
     retryFailureAction:
       name: get-museum-hours-failure-action
       type: retry
-      retryAfter: 3000
+      retryAfter: 3
       retryLimit: 1
       workflowId: final-workflow
       criteria:

__tests__/respect/step-on-failure-type-end-action/step-on-failure-type-end-action.arazzo.yaml

@@ -36,7 +36,7 @@ workflows:
           - type: retry
             name: step-onFailure-action-retry
             retryLimit: 1
-            retryAfter: 3000
+            retryAfter: 3
       - stepId: create-event
         operationPath: '{$sourceDescriptions.museum-api.url}#/paths/~1special-events/post'
         requestBody:

packages/core/src/types/arazzo.ts

@@ -269,8 +269,8 @@ const FailureActionObject: NodeType = {
     type: { type: 'string', enum: ['goto', 'retry', 'end'] },
     workflowId: { type: 'string' },
     stepId: { type: 'string' },
-    retryAfter: { type: 'number' },
-    retryLimit: { type: 'number' },
+    retryAfter: { type: 'number', minimum: 0 },
+    retryLimit: { type: 'number', minimum: 0 },
     criteria: listOf('CriterionObject'),
   },
   required: ['type', 'name'],

packages/respect-core/src/arazzo-schema.ts

@@ -267,8 +267,8 @@ export const onFailureObject = {
     type: { type: 'string', enum: ['goto', 'retry', 'end'] },
     workflowId: { type: 'string' },
     stepId: { type: 'string' },
-    retryAfter: { type: 'number' },
-    retryLimit: { type: 'number' },
+    retryAfter: { type: 'number', minimum: 0 },
+    retryLimit: { type: 'number', minimum: 0 },
     criteria: criteriaObjects,
   },
   additionalProperties: false,

packages/respect-core/src/modules/__tests__/flow-runner/run-step.test.ts

@@ -1453,7 +1453,7 @@ describe('runStep', () => {
           name: 'success-action',
           stepId: 'failure-action-step',
           type: 'retry',
-          retryAfter: 1000,
+          retryAfter: 1,
           retryLimit: 2,
           criteria: [
             {
@@ -1570,7 +1570,7 @@ describe('runStep', () => {
           stepId: 'failure-action-step',
           workflowId: 'failure-action-workflow',
           type: 'retry',
-          retryAfter: 1000,
+          retryAfter: 1,
           retryLimit: 2,
           criteria: [
             {
@@ -1684,7 +1684,7 @@ describe('runStep', () => {
           name: 'success-action',
           stepId: 'failure-action-step',
           type: 'retry',
-          retryAfter: 1000,
+          retryAfter: 1,
           retryLimit: 2,
           criteria: [
             {
@@ -1800,7 +1800,7 @@ describe('runStep', () => {
           name: 'success-action',
           stepId: 'failure-action-step',
           type: 'retry',
-          retryAfter: 1000,
+          retryAfter: 1,
           retryLimit: 2,
           criteria: [
             {
@@ -1950,7 +1950,7 @@ describe('runStep', () => {
           name: 'success-action',
           stepId: 'failure-action-step',
           type: 'retry',
-          retryAfter: 1000,
+          retryAfter: 1,
           retryLimit: 2,
           criteria: [
             {

packages/respect-core/src/modules/flow-runner/run-step.ts

@@ -304,7 +304,8 @@ export async function runStep({
           if (retriesLeft === 0) {
             return { retriesLeft: 0, shouldEnd: false };
           }
-          await delay(retryAfter);
+
+          retryAfter && (await delay(retryAfter));
 
           if (targetWorkflow || targetStep) {
             printActionsSeparator({

packages/respect-core/src/utils/delay.ts

@@ -1,4 +1,4 @@
 /* istanbul ignore file */
-export function delay(ms = 0) {
-  return new Promise((resolve) => setTimeout(resolve, ms));
+export function delay(seconds = 0) {
+  return new Promise((resolve) => setTimeout(resolve, seconds * 1000));
 }