Skip to content

Commit 9eb13ea

Browse files
authored
Update "Can't retrieve a list of commands" error message (#101)
1 parent b6e97cf commit 9eb13ea

File tree

12 files changed

+846
-866
lines changed

12 files changed

+846
-866
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ jobs:
117117
echo "::set-output name=checksum::$(cat ./${{ steps.metadata.outputs.archive-checksum }} | cut -d' ' -f1)"
118118
119119
- name: Lint plugin
120+
continue-on-error: true
120121
run: |
121122
git clone https://github.com/grafana/plugin-validator
122123
pushd ./plugin-validator/pkg/cmd/plugincheck
@@ -156,9 +157,3 @@ jobs:
156157
asset_path: ./${{ steps.metadata.outputs.archive-checksum }}
157158
asset_name: ${{ steps.metadata.outputs.archive-checksum }}
158159
asset_content_type: text/plain
159-
160-
- name: Publish to Grafana.com
161-
run: |
162-
echo A draft release has been created for your plugin. Please review and publish it. Then submit your plugin to grafana.com/plugins by opening a PR to https://github.com/grafana/grafana-plugin-repository with the following entry:
163-
echo
164-
echo '{ "id": "${{ steps.metadata.outputs.plugin-id }}", "type": "${{ steps.metadata.outputs.plugin-type }}", "url": "https://github.com/${{ github.repository }}", "versions": [ { "version": "${{ steps.metadata.outputs.plugin-version }}", "commit": "${{ github.sha }}", "url": "https://github.com/${{ github.repository }}", "download": { "any": { "url": "https://github.com/${{ github.repository }}/releases/download/v${{ steps.metadata.outputs.plugin-version }}/${{ steps.metadata.outputs.archive }}", "md5": "${{ steps.package-plugin.outputs.checksum }}" } } } ] }' | jq .

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Change Log
22

3-
## 2.2.0 (IN PROGRESS)
3+
## 2.2.0 (2022-01-17)
44

55
### Features / Enhancements
66

@@ -10,6 +10,9 @@
1010
- Upgrade to Grafana 8.3.0 (#93)
1111
- Fix LGTM and Update Panel Options (#95)
1212
- Add Redis CPU Usage panel (#96)
13+
- Update Components naming (#97)
14+
- Add CPU Usage Stacking and Gradient (#98)
15+
- Update "Can't retrieve a list of commands" error message (#100)
1316

1417
## 2.1.0 (2021-11-10)
1518

Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ ARG DEBIAN_FRONTEND=noninteractive
88
# Set Grafana options
99
ENV GF_ENABLE_GZIP="true"
1010
ENV GF_USERS_DEFAULT_THEME="light"
11-
ENV GF_FEATURE_TOGGLES_ENABLE="ngalert"
12-
ENV GF_PLUGINS_PLUGIN_ADMIN_ENABLED="true"
1311

1412
# Paths
1513
ENV GF_PATHS_PROVISIONING="/etc/grafana/provisioning"

LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@
187187
identification within third-party archives.
188188

189189
Copyright 2020 Redis Labs
190-
Copyright 2021 Mikhail Volkov
190+
Copyright 2021-2022 Volkov Labs
191191

192192
Licensed under the Apache License, Version 2.0 (the "License");
193193
you may not use this file except in compliance with the License.

docker-compose.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ services:
1919
- GF_ENABLE_GZIP=true
2020
- GF_USERS_DEFAULT_THEME=light
2121
- GF_INSTALL_PLUGINS=redis-app
22-
- GF_FEATURE_TOGGLES_ENABLE=ngalert
23-
- GF_PLUGINS_PLUGIN_ADMIN_ENABLED=true
2422
volumes:
2523
- ./provisioning:/etc/grafana/provisioning
2624
# Uncomment to preserve Grafana configuration

docker-compose/dev.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ services:
2323
- GF_ENABLE_GZIP=true
2424
- GF_USERS_DEFAULT_THEME=light
2525
- GF_PLUGINS_ALLOW_LOADING_UNSIGNED_PLUGINS=redis-app,redis-datasource
26-
- GF_FEATURE_TOGGLES_ENABLE=ngalert
27-
- GF_PLUGINS_PLUGIN_ADMIN_ENABLED=true
26+
- GF_DEFAULT_APP_MODE=development
2827
# Uncomment to run in debug mode
2928
# - GF_LOG_LEVEL=debug
3029
volumes:

docker-compose/master.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ services:
2323
- GF_ENABLE_GZIP=true
2424
- GF_USERS_DEFAULT_THEME=light
2525
- GF_PLUGINS_ALLOW_LOADING_UNSIGNED_PLUGINS=redis-app,redis-datasource
26-
- GF_FEATURE_TOGGLES_ENABLE=ngalert
27-
- GF_PLUGINS_PLUGIN_ADMIN_ENABLED=true
26+
- GF_DEFAULT_APP_MODE=development
2827
# Uncomment to run in debug mode
2928
# - GF_LOG_LEVEL=debug
3029
volumes:

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"@grafana/toolkit": "8.3.0",
88
"@grafana/ui": "8.3.0",
99
"@monaco-editor/react": "^4.3.1",
10-
"@types/enzyme": "^3.10.10",
10+
"@types/enzyme": "^3.10.11",
1111
"@types/enzyme-adapter-react-16": "^1.0.6",
1212
"emotion": "11.0.0",
1313
"enzyme": "^3.11.0",

src/components/DataSourceList/DataSourceList.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ describe('DataSourceList', () => {
3939
};
4040
const TITLES = {
4141
success: 'Working as expected',
42-
error: `Can't retrieve a list of commands`,
42+
error: `Can't retrieve a list of commands. Check that user has permissions to see a list of all commands.`,
4343
};
4444

4545
beforeEach(() => {

src/components/DataSourceList/DataSourceList.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,9 @@ export const DataSourceList: FC<Props> = ({ dataSources }) => {
9797
<section className="card-section card-list-layout-list">
9898
<ol className="card-list">
9999
{dataSources.map((redis, index) => {
100-
const title = redis.commands?.length ? 'Working as expected' : "Can't retrieve a list of commands";
100+
const title = redis.commands?.length
101+
? 'Working as expected'
102+
: "Can't retrieve a list of commands. Check that user has permissions to see a list of all commands.";
101103
const fill = redis.commands?.length ? '#DC382D' : '#A7A7A7';
102104
const url = redis.url ? redis.url : 'Not specified';
103105

src/plugin.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"id": "redis-datasource",
88
"name": "Redis Data Source",
99
"type": "datasource",
10-
"version": "^2.0.0"
10+
"version": "^2.1.0"
1111
}
1212
]
1313
},

0 commit comments

Comments
 (0)