Update VMI pause/unpause (#2596) (#2602)

removed wait_for_domstate_pause_status from pause/unpause
(when called with wait=True):
  1. check for domstate was an old w/a with is irrelevant now
  2. executing domstate command on virt-launhcer pod can be done
     only with admin client (even though pause/unpause can be
     executed by unpriv client)

Co-authored-by: vsibirsk <[email protected]>

Author: rh-bot-1

ocp_resources/virtual_machine_instance.py

@@ -1,5 +1,6 @@
 import shlex
 from typing import Any
+from warnings import warn
 
 import xmltodict
 from kubernetes.dynamic.exceptions import ResourceNotFoundError
@@ -151,10 +152,14 @@ def wait_for_pause_status(self, pause, timeout=TIMEOUT_4MINUTES):
             TimeoutExpiredError: If resource not exists.
         """
         self.logger.info(f"Wait until {self.kind} {self.name} is {'Paused' if pause else 'Unpuased'}")
-        self.wait_for_domstate_pause_status(pause=pause, timeout=timeout)
         self.wait_for_vmi_condition_pause_status(pause=pause, timeout=timeout)
 
     def wait_for_domstate_pause_status(self, pause, timeout=TIMEOUT_4MINUTES):
+        warn(
+            message="wait_for_domstate_pause_status is deprecated and will be removed the next version.",
+            category=DeprecationWarning,
+            stacklevel=2,
+        )
         pause_status = "paused" if pause else "running"
         samples = TimeoutSampler(
             wait_timeout=timeout,
@@ -269,6 +274,11 @@ def get_domstate(self):
         Returns:
             String: VMI Status as string
         """
+        warn(
+            message="get_domstate is deprecated and will be removed the next version.",
+            category=DeprecationWarning,
+            stacklevel=2,
+        )
         return self.execute_virsh_command(command="domstate")
 
     def get_dommemstat(self):