fix(RHINENG-8416): Do not open menu on checkbox click

RedHatInsights · Oct 22, 2024 · dacd72a · dacd72a
1 parent 6bbd0a0
commit dacd72a
Showing 1 changed file with 12 additions and 19 deletions.
diff --git a/packages/components/src/BulkSelect/BulkSelect.tsx b/packages/components/src/BulkSelect/BulkSelect.tsx
@@ -83,25 +83,18 @@ const BulkSelect: React.FunctionComponent<BulkSelectProps> = ({
                 toggleProps?.children
               ) : (
                 <Fragment key="split-checkbox">
-                  {hasError ? (
-                    <MenuToggleCheckbox
-                      id={id ? `${id}-toggle-checkbox` : 'toggle-checkbox'}
-                      aria-label="Select all"
-                      onChange={onSelect}
-                      isChecked={checked}
-                      ouiaId={checkboxOuiaId ?? 'BulkSelectCheckbox'}
-                    />
-                  ) : (
-                    <MenuToggleCheckbox
-                      id={id ? `${id}-toggle-checkbox` : 'toggle-checkbox'}
-                      aria-label="Select all"
-                      onChange={onSelect}
-                      isChecked={checked}
-                      ouiaId={checkboxOuiaId ?? 'BulkSelectCheckbox'}
-                    >
-                      {count ? `${count} selected` : ''}
-                    </MenuToggleCheckbox>
-                  )}
+                  <MenuToggleCheckbox
+                    id={id ? `${id}-toggle-checkbox` : 'toggle-checkbox'}
+                    aria-label="Select all"
+                    onChange={(checked, event) => {
+                      setIsOpen(false);
+                      onSelect?.(checked, event);
+                    }}
+                    isChecked={checked}
+                    ouiaId={checkboxOuiaId ?? 'BulkSelectCheckbox'}
+                  >
+                    {!hasError && count ? `${count} selected` : ''}
+                  </MenuToggleCheckbox>
                 </Fragment>
               )}
             </MenuToggle>