Skip to content

Commit

Permalink
Merge pull request #2079 from RedHatInsights/revert-2076-require_version
Browse files Browse the repository at this point in the history
Revert "fix: typo in version check"
  • Loading branch information
Hyperkid123 authored Oct 14, 2024
2 parents b476ae8 + a7e1457 commit c4934e5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/config-utils/src/federated-modules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function hasVersionSpecified(config: { [module: string]: WebpackSharedConfig }):
requiredVersion: string;
};
} {
return Object.values(config).every((c) => typeof c.requiredVersion === 'string');
return Object.values(config).every((c) => typeof c.version === 'string');
}

const federatedModules = ({
Expand Down Expand Up @@ -76,7 +76,7 @@ const federatedModules = ({
shared.forEach((dep) => {
if (!hasVersionSpecified(dep)) {
const invalidDeps = Object.entries(dep)
.filter(([, { requiredVersion }]) => typeof requiredVersion !== 'string')
.filter(([, { version }]) => typeof version !== 'string')
.map(([moduleName]) => moduleName);
throw new Error('Some of your shared dependencies do not have version specified! Dependencies with no version: ' + invalidDeps);
}
Expand Down

0 comments on commit c4934e5

Please sign in to comment.