fix: change validation response condition and fix jsDoc

Real-Dev-Squad · Jan 22, 2025 · f76bd41 · f76bd41
1 parent 36ca944
commit f76bd41
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/controllers/onboardingExtension.ts b/controllers/onboardingExtension.ts
@@ -238,7 +238,7 @@ export const updateOnboardingExtensionRequestController = async (
             body.newEndsOn,
         )
 
-        if ('error' in validationResponse){
+        if (validationResponse){
             if(validationResponse.error === REQUEST_DOES_NOT_EXIST){
                 return res.boom.notFound(validationResponse.error);
             }

diff --git a/controllers/requests.ts b/controllers/requests.ts
@@ -114,7 +114,6 @@ export const getRequestsController = async (req: any, res: any) => {
  * @param {CustomResponse} res - The response object.
  * @returns {Promise<void>} Resolves or sends an error for invalid types.
  */
-
 export const updateRequestBeforeAcknowledgedController = async (req: Request, res: CustomResponse) => {
   const type = req.body.type;
   switch(type){

diff --git a/services/onboardingExtension.ts b/services/onboardingExtension.ts
@@ -91,7 +91,7 @@ export const validateOnboardingExtensionUpdateRequest = async (
 /**
  * Updates an onboarding extension request.
  * 
- * @param {object} extensionRequestDoc - The extension request document.
+ * @param {string} id - The extension request document.
  * @param {UpdateOnboardingExtensionRequestBody} body - New request details.
  * @param {string} lastModifiedBy - ID of the user updating the request.
  * @returns {Promise<object>} Updated request body.