Skip to content

Commit 85ea7d3

Browse files
AnujChhikaraAnujChhikara
authored
chore:remove feature flag from get progresses api (#2380)
1 parent f8d0bc7 commit 85ea7d3

File tree

3 files changed

+4
-166
lines changed

3 files changed

+4
-166
lines changed

‎models/progresses.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,11 @@ const createProgressDocument = async (progressData) => {
5050
* @throws {Error} If the userId or taskId is invalid or does not exist.
5151
**/
5252
const getProgressDocument = async (queryParams) => {
53-
const { dev } = queryParams;
5453
await assertUserOrTaskExists(queryParams);
5554
const query = buildQueryToFetchDocs(queryParams);
5655
const progressDocs = await getProgressDocs(query);
5756

58-
if (dev === "true") {
59-
return await addUserDetailsToProgressDocs(progressDocs);
60-
}
61-
return progressDocs;
57+
return await addUserDetailsToProgressDocs(progressDocs);
6258
};
6359

6460
/**

‎test/integration/progressesTasks.test.js

Lines changed: 2 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -212,61 +212,7 @@ describe("Test Progress Updates API for Tasks", function () {
212212
"type",
213213
"completed",
214214
"planned",
215-
"blockers",
216-
"userId",
217-
"createdAt",
218-
"date",
219-
]);
220-
});
221-
return done();
222-
});
223-
});
224-
225-
it("Returns the progress array for the task with userData object", function (done) {
226-
chai
227-
.request(app)
228-
.get(`/progresses?taskId=${taskId1}&dev=true`)
229-
.end((err, res) => {
230-
if (err) return done(err);
231-
expect(res).to.have.status(200);
232-
expect(res.body).to.have.keys(["message", "data", "count", "links"]);
233-
expect(res.body.data).to.be.an("array");
234-
expect(res.body.message).to.be.equal("Progress document retrieved successfully.");
235-
res.body.data.forEach((progress) => {
236-
expect(progress).to.have.keys([
237-
"id",
238-
"taskId",
239-
"type",
240-
"completed",
241-
"planned",
242-
"blockers",
243215
"userData",
244-
"userId",
245-
"createdAt",
246-
"date",
247-
]);
248-
});
249-
return done();
250-
});
251-
});
252-
253-
it("Returns the progress array for the task without userData field if dev is false", function (done) {
254-
chai
255-
.request(app)
256-
.get(`/progresses?taskId=${taskId1}&dev=false`)
257-
.end((err, res) => {
258-
if (err) return done(err);
259-
expect(res).to.have.status(200);
260-
expect(res.body).to.have.keys(["message", "data", "count"]);
261-
expect(res.body.data).to.be.an("array");
262-
expect(res.body.message).to.be.equal("Progress document retrieved successfully.");
263-
res.body.data.forEach((progress) => {
264-
expect(progress).to.have.keys([
265-
"id",
266-
"taskId",
267-
"type",
268-
"completed",
269-
"planned",
270216
"blockers",
271217
"userId",
272218
"createdAt",
@@ -371,36 +317,8 @@ describe("Test Progress Updates API for Tasks", function () {
371317
"type",
372318
"completed",
373319
"planned",
374-
"blockers",
375-
"userId",
376-
"createdAt",
377-
"date",
378-
]);
379-
});
380-
return done();
381-
});
382-
});
383-
384-
it("Returns the progress array for all the tasks with userData object", function (done) {
385-
chai
386-
.request(app)
387-
.get(`/progresses?type=task&dev=true`)
388-
.end((err, res) => {
389-
if (err) return done(err);
390-
expect(res).to.have.status(200);
391-
expect(res.body).to.have.keys(["message", "data", "count", "links"]);
392-
expect(res.body.data).to.be.an("array");
393-
expect(res.body.message).to.be.equal("Progress document retrieved successfully.");
394-
expect(res.body.count).to.be.equal(4);
395-
res.body.data.forEach((progress) => {
396-
expect(progress).to.have.keys([
397-
"id",
398-
"taskId",
399-
"type",
400-
"completed",
401-
"planned",
402-
"blockers",
403320
"userData",
321+
"blockers",
404322
"userId",
405323
"createdAt",
406324
"date",
@@ -681,6 +599,7 @@ describe("Test Progress Updates API for Tasks", function () {
681599
"planned",
682600
"blockers",
683601
"userId",
602+
"userData",
684603
"taskId",
685604
"createdAt",
686605
"date",

‎test/integration/progressesUsers.test.js

Lines changed: 1 addition & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ describe("Test Progress Updates API for Users", function () {
192192
"planned",
193193
"blockers",
194194
"userId",
195+
"userData",
195196
"createdAt",
196197
"date",
197198
]);
@@ -210,59 +211,6 @@ describe("Test Progress Updates API for Users", function () {
210211
expect(res.body).to.have.keys(["message", "data", "count"]);
211212
expect(res.body.data).to.be.an("array");
212213
expect(res.body.message).to.be.equal("Progress document retrieved successfully.");
213-
res.body.data.forEach((progress) => {
214-
expect(progress).to.have.keys([
215-
"id",
216-
"type",
217-
"completed",
218-
"planned",
219-
"blockers",
220-
"userId",
221-
"createdAt",
222-
"date",
223-
]);
224-
});
225-
return done();
226-
});
227-
});
228-
229-
it("Returns the progress array for a specific user with userData object", function (done) {
230-
chai
231-
.request(app)
232-
.get(`/progresses?userId=${userId1}&dev=true`)
233-
.end((err, res) => {
234-
if (err) return done(err);
235-
expect(res).to.have.status(200);
236-
expect(res.body).to.have.keys(["message", "data", "count", "links"]);
237-
expect(res.body.data).to.be.an("array");
238-
expect(res.body.message).to.be.equal("Progress document retrieved successfully.");
239-
res.body.data.forEach((progress) => {
240-
expect(progress).to.have.keys([
241-
"id",
242-
"type",
243-
"completed",
244-
"planned",
245-
"blockers",
246-
"userId",
247-
"userData",
248-
"createdAt",
249-
"date",
250-
]);
251-
});
252-
return done();
253-
});
254-
});
255-
256-
it("Returns the progress array for all the user with userData object when dev is true", function (done) {
257-
chai
258-
.request(app)
259-
.get(`/progresses?type=user&dev=true`)
260-
.end((err, res) => {
261-
if (err) return done(err);
262-
expect(res).to.have.status(200);
263-
expect(res.body).to.have.keys(["message", "data", "count", "links"]);
264-
expect(res.body.data).to.be.an("array");
265-
expect(res.body.message).to.be.equal("Progress document retrieved successfully.");
266214
res.body.data.forEach((progress) => {
267215
expect(progress).to.have.keys([
268216
"id",
@@ -424,31 +372,6 @@ describe("Test Progress Updates API for Users", function () {
424372
});
425373
});
426374

427-
it("Returns the progress data for a specific user with userData object", function (done) {
428-
chai
429-
.request(app)
430-
.get(`/progresses/user/${userId}/date/2023-05-02?dev=true`)
431-
.end((err, res) => {
432-
if (err) return done(err);
433-
expect(res).to.have.status(200);
434-
expect(res.body).to.have.keys(["message", "data"]);
435-
expect(res.body.data).to.be.an("object");
436-
expect(res.body.message).to.be.equal("Progress document retrieved successfully.");
437-
expect(res.body.data).to.have.keys([
438-
"id",
439-
"type",
440-
"completed",
441-
"planned",
442-
"blockers",
443-
"userData",
444-
"userId",
445-
"createdAt",
446-
"date",
447-
]);
448-
return done();
449-
});
450-
});
451-
452375
it("Should return 404 No progress records found if the document doesn't exist", function (done) {
453376
chai
454377
.request(app)

0 commit comments

Comments
 (0)