[commands] Add guild(s) kwarg to BotBase.add_command and correct BotBase.add_cog doc #9428
+58
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9366
This PR adds the following kwargs to
Bot.add_command
:guild
andguilds
for hybrid app commands. This allows defining guilds for a hybrid app command while adding it to the bot, these are also used by the lib inBotBase.add_cog
if any guild(s) were passed to that.This PR also corrects the doc of the
guild(s)
kwargs inBotBase.add_cog
which previously led users to believe that the kwargs are only valid for GroupCog/app_commands.Group which is not the case.This can be a breaking change since previously hybrid app commands in cogs were not added as guild commands when the guild kwargs in add_cog were used. This could lead to unexpected behaviour.
I have not tested all possibilities/edge cases(if any) with the new kwargs for add_command.
Checklist