Skip to content

Conversation

@Ze-Hou
Copy link
Contributor

@Ze-Hou Ze-Hou commented Nov 12, 2025

拉取/合并请求描述:(PR description)

Relates to #10895
[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions github-actions bot added the Kernel PR has src relate code label Nov 12, 2025
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

📌 Code Review Assignment

🏷️ Tag: kernel

Reviewers: GorrayLi ReviewSun hamburger-os lianux-mm wdfk-prog xu18838022837

Changed Files (Click to expand)
  • src/utest/thread_tc.c

📊 Current Review Status (Last Updated: 2025-11-13 10:05 CST)

  • GorrayLi Pending Review
  • ReviewSun Pending Review
  • hamburger-os Pending Review
  • lianux-mm Pending Review
  • wdfk-prog Pending Review
  • xu18838022837 Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:dev_1
  • 设置PR number为 \ Set the PR number to:10924
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 dev_1 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the dev_1 branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive standardized documentation to the thread_tc.c unit test file, improving test clarity and maintainability by documenting test objectives, scenarios, verification metrics, dependencies, and expected results.

  • Adds a detailed documentation block explaining the thread test case structure
  • Updates the changelog with the new documentation addition
  • Provides clear guidance for developers on test purpose, execution, and validation

* - Time-slice scheduling distributes CPU time fairly among threads of the same priority (difference < 30%)
*
* Dependencies:
* - Enable Thread Test(RT-Thread Utestcases -> Kernel Core -> Thread Test)
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after "Test" in Dependencies section.

English: In line 47, there should be a space between "Test" and the opening parenthesis. It should read "Enable Thread Test (RT-Thread..." instead of "Enable Thread Test(RT-Thread...".

中文:在第47行中,"Test"和左括号之间应该有一个空格。应该是"Enable Thread Test (RT-Thread..."而不是"Enable Thread Test(RT-Thread..."。

Suggested change
* - Enable Thread Test(RT-Thread Utestcases -> Kernel Core -> Thread Test)
* - Enable Thread Test (RT-Thread Utestcases -> Kernel Core -> Thread Test)

Copilot uses AI. Check for mistakes.
*
* Change Logs:
* Date Author Notes
* 2021-09.01 yangjie the firet version
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error in the changelog: "firet" should be "first".

English: The word "firet" on line 8 is misspelled and should be "first". This typo exists in the original code (not introduced by this PR), but since line 10 is being added next to it, it would be good to fix this existing typo as well for consistency.

中文:第8行中的单词"firet"拼写错误,应该是"first"。这个拼写错误存在于原始代码中(不是本PR引入的),但由于第10行正在其旁边添加,建议同时修复这个现有的拼写错误以保持一致性。

Suggested change
* 2021-09.01 yangjie the firet version
* 2021-09.01 yangjie the first version

Copilot uses AI. Check for mistakes.
@Ze-Hou
Copy link
Contributor Author

Ze-Hou commented Nov 13, 2025

@Rbb666 老师,已经修改好了

@Rbb666 Rbb666 merged commit ec5e72c into RT-Thread:master Nov 13, 2025
57 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in 单元测试(UTEST)Framework Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kernel PR has src relate code

Projects

Development

Successfully merging this pull request may close these issues.

2 participants