ROCm 8.0.0 -- libffts Dynamic link and Submodule

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "third_party/ffts"]
+	path = third_party/ffts
+	url = https://github.com/anthonix/ffts.git

CMakeLists.txt

@@ -161,8 +161,17 @@ find_package(HALF REQUIRED)
 include_directories(${HALF_INCLUDE_DIRS})
 
 if (RPP_AUDIO_SUPPORT)
-    add_definitions(-DAUDIO_SUPPORT)        # For compile flags in RPP
-    set(RPP_AUDIO_AUGMENTATIONS_SUPPORT 1)  # For cmakedefine01 in rpp_audio_augmentations_support.h.in
+    find_package(FFTS QUIET)
+    if(FFTS_FOUND)
+        add_definitions(-DAUDIO_SUPPORT)        # For compile flags in RPP
+        set(RPP_AUDIO_AUGMENTATIONS_SUPPORT 1)  # For cmakedefine01 in rpp_audio_augmentations_support.h.in
+        message("-- ${Green}${PROJECT_NAME} set to build with RPP_AUDIO_SUPPORT${ColourReset}")
+    else()
+        set(RPP_AUDIO_SUPPORT OFF)              # Disable audio support if FFTS not found
+        message("-- ${Yellow}FFTS not found. ${PROJECT_NAME} set to build without RPP_AUDIO_SUPPORT${ColourReset}")
+    endif()
+else()
+    message("-- ${Yellow}${PROJECT_NAME} set to build without RPP_AUDIO_SUPPORT${ColourReset}")
 endif()
 
 if (RPP_LEGACY_SUPPORT)
@@ -334,17 +343,13 @@ target_link_libraries(${PROJECT_NAME} ${LINK_LIBRARY_LIST})
 set_target_properties(${PROJECT_NAME} PROPERTIES POSITION_INDEPENDENT_CODE ON)
 set_target_properties(${PROJECT_NAME} PROPERTIES LINKER_LANGUAGE CXX)
 if(RPP_AUDIO_SUPPORT)
-    target_link_libraries(${PROJECT_NAME} ${PROJECT_SOURCE_DIR}/third_party/ffts/lib/libffts.a)
-    message("-- ${Green}${PROJECT_NAME} set to build with RPP_AUDIO_SUPPORT${ColourReset}")
-else()
-    message("-- ${Yellow}${PROJECT_NAME} set to build without RPP_AUDIO_SUPPORT${ColourReset}")
+    target_link_libraries(${PROJECT_NAME} FFTS::FFTS)
 endif()
 set_target_properties(${PROJECT_NAME} PROPERTIES VERSION ${PROJECT_VERSION} SOVERSION ${PROJECT_VERSION_MAJOR})
 
 target_include_directories(${PROJECT_NAME}
     PUBLIC
         ${CMAKE_CURRENT_SOURCE_DIR}/api
-        $<$<BOOL:${RPP_AUDIO_SUPPORT}>:${CMAKE_CURRENT_SOURCE_DIR}/third_party/ffts/include>
         ${ROCM_PATH}/include
     PRIVATE
         ${CMAKE_CURRENT_SOURCE_DIR}/src/include/cpu
@@ -400,9 +405,13 @@ install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/utilities/rpp-performancetests DES
 set(CPACK_RESOURCE_FILE_LICENSE  "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE")
 install(FILES ${CPACK_RESOURCE_FILE_LICENSE} DESTINATION ${CMAKE_INSTALL_DOCDIR} COMPONENT runtime)
 install(FILES ${CPACK_RESOURCE_FILE_LICENSE} DESTINATION ${CMAKE_INSTALL_DOCDIR}-asan COMPONENT asan)
-set(CPACK_RESOURCE_FILE_FFTS_LICENSE  "${CMAKE_CURRENT_SOURCE_DIR}/third_party/ffts/FFTS_LICENSE")
-install(FILES ${CPACK_RESOURCE_FILE_FFTS_LICENSE} DESTINATION ${CMAKE_INSTALL_DOCDIR} COMPONENT runtime)
-install(FILES ${CPACK_RESOURCE_FILE_FFTS_LICENSE} DESTINATION ${CMAKE_INSTALL_DOCDIR}-asan COMPONENT asan)
+if(RPP_AUDIO_SUPPORT AND FFTS_FOUND)
+    set(CPACK_RESOURCE_FILE_FFTS_LICENSE  "${CMAKE_CURRENT_SOURCE_DIR}/third_party/ffts/COPYRIGHT")
+    if(EXISTS ${CPACK_RESOURCE_FILE_FFTS_LICENSE})
+        install(FILES ${CPACK_RESOURCE_FILE_FFTS_LICENSE} DESTINATION ${CMAKE_INSTALL_DOCDIR} COMPONENT runtime)
+        install(FILES ${CPACK_RESOURCE_FILE_FFTS_LICENSE} DESTINATION ${CMAKE_INSTALL_DOCDIR}-asan COMPONENT asan)
+    endif()
+endif()
 
 # Cmake module config file configurations
 set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake_modules/" CACHE INTERNAL "Default module path.")

cmake/FindFFTS.cmake

@@ -0,0 +1,48 @@
+#[[
+Copyright © 2019-2025 Advanced Micro Devices, Inc. or its affiliates.
+SPDX-License-Identifier: MIT
+]]
+
+find_path(FFTS_INCLUDE_DIR
+    NAMES ffts/ffts.h ffts.h
+    PATHS
+        /usr/local/include
+        /usr/include
+        /opt/local/include
+        /opt/include
+    PATH_SUFFIXES ffts
+)
+
+find_library(FFTS_LIBRARY
+    NAMES ffts
+    PATHS
+        /usr/local/lib
+        /usr/lib
+        /usr/local/lib64
+        /usr/lib64
+        /opt/local/lib
+        /opt/lib
+)
+
+# Mark the variables as advanced
+mark_as_advanced(FFTS_INCLUDE_DIR FFTS_LIBRARY)
+
+# Check if we found the library and headers
+include(FindPackageHandleStandardArgs)
+find_package_handle_standard_args(FFTS
+    REQUIRED_VARS FFTS_LIBRARY FFTS_INCLUDE_DIR
+)
+
+if(FFTS_FOUND)
+    set(FFTS_LIBRARIES ${FFTS_LIBRARY})
+    set(FFTS_INCLUDE_DIRS ${FFTS_INCLUDE_DIR})
+endif()
+
+# Create imported target
+if(FFTS_FOUND AND NOT TARGET FFTS::FFTS)
+    add_library(FFTS::FFTS SHARED IMPORTED)
+    set_target_properties(FFTS::FFTS PROPERTIES
+        IMPORTED_LOCATION "${FFTS_LIBRARY}"
+        INTERFACE_INCLUDE_DIRECTORIES "${FFTS_INCLUDE_DIRS}"
+    )
+endif()

src/modules/CMakeLists.txt

@@ -234,7 +234,6 @@ set_target_properties(${PROJECT_NAME} PROPERTIES POSITION_INDEPENDENT_CODE ON)
 target_include_directories( ${PROJECT_NAME}
     PUBLIC
         ${CMAKE_SOURCE_DIR}/api
-        ${CMAKE_SOURCE_DIR}/third_party/ffts/include
         ${ROCM_INC}
     PRIVATE
         $<$<BOOL:${RPP_LEGACY_SUPPORT}>:${CMAKE_SOURCE_DIR}/src/include/batch_pd/cpu>

src/modules/tensor/cpu/kernel/spectrogram.cpp

@@ -23,8 +23,7 @@ SOFTWARE.
 */
 
 #include "host_tensor_executors.hpp"
-#include "ffts.h"
-#include "ffts_attributes.h"
+#include <ffts/ffts.h>
 #include <complex>
 
 inline bool is_pow2(Rpp64s n) { return (n & (n-1)) == 0; }
@@ -181,8 +180,8 @@ RppStatus spectrogram_host_tensor(Rpp32f *srcPtr,
         }
 
         // Set temporary buffers to 0
-        Rpp32f FFTS_ALIGN(32) *fftInBuf = static_cast<Rpp32f*>(_mm_malloc(fftInSize * sizeof(Rpp32f), 32)); // ffts requires 32-byte aligned memory
-        Rpp32f FFTS_ALIGN(32) *fftOutBuf = static_cast<Rpp32f*>(_mm_malloc(fftOutSize * sizeof(Rpp32f), 32)); // ffts requires 32-byte aligned memory
+        alignas(32) Rpp32f *fftInBuf = static_cast<Rpp32f*>(_mm_malloc(fftInSize * sizeof(Rpp32f), 32)); // ffts requires 32-byte aligned memory
+        alignas(32) Rpp32f *fftOutBuf = static_cast<Rpp32f*>(_mm_malloc(fftOutSize * sizeof(Rpp32f), 32)); // ffts requires 32-byte aligned memory
 
         for (Rpp32s w = 0; w < numWindows; w++)
         {