add stream capture checks for MemPool APIs and tests

[lttamd]

Motivation

add stream capture checks and tests for MemPool APIs

Technical Details

Add CHECK_STREAM_CAPTURE_SUPPORTED() to 11 MemPool API functions
so they return hipErrorStreamCaptureUnsupported when called
during non-relaxed stream capture.

Add corresponding stream capture tests for each affected API:
hipMemPoolTrimTo, hipMemPoolSetAttribute, hipMemPoolGetAttribute,
hipMemPoolSetAccess, hipMemPoolGetAccess, hipMemPoolCreate,
hipMemPoolDestroy, hipMemPoolExportToShareableHandle,
hipMemPoolImportFromShareableHandle, hipMemPoolExportPointer,
hipMemPoolImportPointer.

Issue Tracking

ROCM-22689

Test Plan

The tests in this PR

Test Result

Passed with the clr change in this PR.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

[therock-pr-bot]

❌ PR Check — Action Required

Check	Status	Details
📝 PR Description	❌ Fail	Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword. Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples: • JIRA ID : TESTAUTO-6039 • JIRA ID - #330 • JIRA ID #330 • JIRA ID (on separate line) ROCM-25757 • ISSUE ID : TESTUTO-3334 • ISSUE ID #3334 • ISSUE ID - TESTAUTO-3433 • ISSUE ID (on separate line) AIRUNTIME-2352 • ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234 • Closes #10 • Fixes octo-org/octo-repo#100 • Resolves: #123 • #123 • https://github.com/<org_name>/<repo_name>/issues/123 Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	⚠️ Warning	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*). Current: code file(s) changed: projects/clr/hipamd/src/hip_mempool.cpp, projects/hip-tests/catch/unit/memory/hipMemPoolCreate.cc, projects/hip-tests/catch/unit/memory/hipMemPoolDestroy.cc, projects/hip-tests/catch/unit/memory/hipMemPoolExportPointer.cc, projects/hip-tests/catch/unit/memory/hipMemPoolExportToShareableHandle.cc (+5 more); no test file found
🔎 pre-commit	⏳ Pending	⏳ Still running…
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

• ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

• ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

[Copilot]

Pull request overview

Adds new Catch2 unit tests in the HIP test suite to validate expected behavior of several MemPool APIs when invoked during stream capture (relaxed mode allowed; global/thread-local modes return hipErrorStreamCaptureUnsupported).

Changes:

• Added new *_Capture test cases for multiple MemPool APIs (create/destroy/trim/set-get attribute/set-get access/export/import).
• Registered the new tests in catch/config/configs/unit/memory.yaml with [alloc, capture] tags.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
projects/hip-tests/catch/unit/memory/hipMemPoolTrimTo.cc	Adds Unit_hipMemPoolTrimTo_Capture stream-capture behavior test.
projects/hip-tests/catch/unit/memory/hipMemPoolSetGetAttribute.cc	Adds Unit_hipMemPoolSetAttribute_Capture and Unit_hipMemPoolGetAttribute_Capture tests.
projects/hip-tests/catch/unit/memory/hipMemPoolSetGetAccess.cc	Adds Unit_hipMemPoolSetAccess_Capture and Unit_hipMemPoolGetAccess_Capture tests.
projects/hip-tests/catch/unit/memory/hipMemPoolImportPointer.cc	Adds Unit_hipMemPoolImportPointer_Capture test.
projects/hip-tests/catch/unit/memory/hipMemPoolImportFromShareableHandle.cc	Adds Unit_hipMemPoolImportFromShareableHandle_Capture test.
projects/hip-tests/catch/unit/memory/hipMemPoolExportToShareableHandle.cc	Adds Unit_hipMemPoolExportToShareableHandle_Capture test.
projects/hip-tests/catch/unit/memory/hipMemPoolExportPointer.cc	Adds Unit_hipMemPoolExportPointer_Capture test.
projects/hip-tests/catch/unit/memory/hipMemPoolDestroy.cc	Adds Unit_hipMemPoolDestroy_Capture test.
projects/hip-tests/catch/unit/memory/hipMemPoolCreate.cc	Adds Unit_hipMemPoolCreate_Capture test.
projects/hip-tests/catch/config/configs/unit/memory.yaml	Registers the new capture tests and tags them.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[mangupta]

🤖 AI-assisted pre-review (for @mangupta)

[IMPORTANT] Public-API behavior change has no contract test / uncovered_apis rationale and TEST_PLAN.md is not regenerated

The PR changes a public-API invariant for eleven APIs (they must now return hipErrorStreamCaptureUnsupported during non-relaxed capture) but adds coverage only under catch/unit/memory/. There is no projects/hip-tests/catch/contract/ test with an @asserts: API - invariant annotation, no entry added to projects/hip-tests/catch/contract/uncovered_apis.txt, and no update to the generated projects/hip-tests/catch/TEST_PLAN.md even though the test configuration (catch/config/configs/unit/memory.yaml) changed.

Suggested fix: Add a catch/contract/ test asserting the capture invariant for the affected mempool APIs (using the format in catch/contract/AUTHORING.md), or record a concrete rationale in catch/contract/uncovered_apis.txt, and regenerate catch/TEST_PLAN.md so it reflects the new cases and config entries.

[mangupta]

🤖 AI-assisted pre-review (for @mangupta)

Re-reviewed the updated head (0ffdf6661a6f) — no new findings at or above the posting threshold.

[mangupta]

🤖 AI-assisted pre-review (for @mangupta)

Re-reviewed the updated head (73a9e7d99063) — no new findings at or above the posting threshold.

[mangupta]

🤖 AI-assisted pre-review (for @mangupta)

Re-reviewed the updated head (2f7447f785da) — no new findings at or above the posting threshold.