From 648d03f8bb34f20af200fe1d68d2ced4058aef4a Mon Sep 17 00:00:00 2001 From: "Wimalasuriyan, Sajeeth" Date: Wed, 25 Feb 2026 15:11:52 -0500 Subject: [PATCH 1/3] Fixed warnings associated with build. --- .../legacy/rocprofvis_compute_block.cpp | 3 ++- .../legacy/rocprofvis_compute_table.cpp | 2 +- .../compute/rocprofvis_compute_roofline.cpp | 20 +++++++++---------- .../src/compute/rocprofvis_compute_view.cpp | 2 +- .../rocprofvis_compute_workload_view.cpp | 4 ++-- src/view/src/rocprofvis_annotation_view.cpp | 1 + src/view/src/rocprofvis_minimap.cpp | 5 +++-- src/view/src/rocprofvis_project.cpp | 4 ++-- src/view/src/rocprofvis_settings_manager.cpp | 4 ++-- src/view/src/rocprofvis_stickynote.cpp | 1 + src/view/src/rocprofvis_summary_view.cpp | 17 ++++++++-------- src/view/src/rocprofvis_timeline_arrow.cpp | 10 +++++----- src/view/src/rocprofvis_timeline_view.cpp | 1 + src/view/src/rocprofvis_track_item.cpp | 1 + src/view/src/rocprofvis_track_topology.cpp | 2 +- .../src/widgets/rocprofvis_compute_widget.cpp | 13 ++++++------ .../rocprofvis_infinite_scroll_table.cpp | 2 +- 17 files changed, 50 insertions(+), 42 deletions(-) diff --git a/src/view/src/compute/legacy/rocprofvis_compute_block.cpp b/src/view/src/compute/legacy/rocprofvis_compute_block.cpp index e6683148..fa908137 100644 --- a/src/view/src/compute/legacy/rocprofvis_compute_block.cpp +++ b/src/view/src/compute/legacy/rocprofvis_compute_block.cpp @@ -203,7 +203,7 @@ ComputeBlockViewLegacy::ComputeBlockViewLegacy(std::string owner_id, std::shared , m_block_diagram_region(ImVec2(-1, -1)) , m_block_diagram_center(ImVec2(-1, -1)) , m_navigation_changed(true) -, m_navigation_event_token(-1) +, m_navigation_event_token(static_cast(-1)) , m_owner_id(owner_id) { m_navigation = std::make_unique(); @@ -252,6 +252,7 @@ ComputeBlockViewLegacy::ComputeBlockViewLegacy(std::string owner_id, std::shared auto navigation_changed_handler = [this](std::shared_ptr event) { + (void)event; m_navigation_changed = true; }; m_navigation_event_token = EventManager::GetInstance()->Subscribe(static_cast(RocEvents::kComputeBlockNavigationChanged), navigation_changed_handler); diff --git a/src/view/src/compute/legacy/rocprofvis_compute_table.cpp b/src/view/src/compute/legacy/rocprofvis_compute_table.cpp index 86b8d30d..b0d0b2b8 100644 --- a/src/view/src/compute/legacy/rocprofvis_compute_table.cpp +++ b/src/view/src/compute/legacy/rocprofvis_compute_table.cpp @@ -87,7 +87,7 @@ const std::array TAB_DEFINITIONS { }; ComputeTableCategory::ComputeTableCategory(std::shared_ptr data_provider, table_view_category_t category) -: m_search_event_token(-1) +: m_search_event_token(static_cast(-1)) { for (const rocprofvis_controller_compute_table_types_t& table : TAB_DEFINITIONS[category].m_table_types) { diff --git a/src/view/src/compute/rocprofvis_compute_roofline.cpp b/src/view/src/compute/rocprofvis_compute_roofline.cpp index 68416f8f..70b9145e 100644 --- a/src/view/src/compute/rocprofvis_compute_roofline.cpp +++ b/src/view/src/compute/rocprofvis_compute_roofline.cpp @@ -390,7 +390,7 @@ Roofline::Render() display &= m_items[i].visible; if(display) { - ImGui::PushID(i); + ImGui::PushID(static_cast(i)); bool hovered = m_hovered_item_idx && m_hovered_item_idx.value() == i; switch(m_items[i].type) @@ -398,7 +398,7 @@ Roofline::Render() case ItemModel::Type::CeilingCompute: case ItemModel::Type::CeilingBandwidth: { - ImPlot::SetNextLineStyle(ImPlot::GetColormapColor(i), + ImPlot::SetNextLineStyle(ImPlot::GetColormapColor(static_cast(i)), hovered ? plot_style.LineWeight * 3.0f : plot_style.LineWeight); @@ -436,8 +436,8 @@ Roofline::Render() (m_scale_intensity ? m_items[i].weight : 0.0f) * 2.0f * plot_style.MarkerSize + (hovered ? plot_style.MarkerSize : 0.0f), - ImPlot::GetColormapColor(i), IMPLOT_AUTO, - ImPlot::GetColormapColor(i)); + ImPlot::GetColormapColor(static_cast(i)), IMPLOT_AUTO, + ImPlot::GetColormapColor(static_cast(i))); ImPlot::PlotScatter( "", &m_items[i].info.intensity->position.x, &m_items[i].info.intensity->position.y, 1); @@ -464,7 +464,7 @@ Roofline::Render() ImGui::CalcTextSize( m_items[i].label.c_str()), ImGui::GetColorU32( - ImPlot::GetColormapColor(i))); + ImPlot::GetColormapColor(static_cast(i)))); ImGui::TextUnformatted(m_items[i].label.c_str()); ImGui::Text( "%.0f GFLOP/s", @@ -480,7 +480,7 @@ Roofline::Render() ImGui::CalcTextSize( m_items[i].label.c_str()), ImGui::GetColorU32( - ImPlot::GetColormapColor(i))); + ImPlot::GetColormapColor(static_cast(i)))); ImGui::TextUnformatted(m_items[i].label.c_str()); ImGui::Text( "%.0f GB/s", @@ -498,7 +498,7 @@ Roofline::Render() DISPLAY_NAMES_KERNEL_INTENSITY [m_items[i].subtype.intensity]), ImGui::GetColorU32( - ImPlot::GetColormapColor(i))); + ImPlot::GetColormapColor(static_cast(i)))); ImGui::TextUnformatted( DISPLAY_NAMES_KERNEL_INTENSITY [m_items[i].subtype.intensity]); @@ -672,7 +672,7 @@ Roofline::RenderMenus(const ImVec2 region, const ImGuiStyle& style, (m_menus_mode == Legend && m_items[i].visible || m_menus_mode == Options)) { empty = false; - ImGui::PushID(i); + ImGui::PushID(static_cast(i)); ImVec2 pos = ImGui::GetCursorPos(); bool row_clicked = ImGui::Selectable( "", false, @@ -697,7 +697,7 @@ Roofline::RenderMenus(const ImVec2 region, const ImGuiStyle& style, ImVec2(icon_width - 2 * IMPLOT_LEGEND_ICON_SHRINK, icon_width - 2 * IMPLOT_LEGEND_ICON_SHRINK), ImGui::GetColorU32( - ImGui::GetColorU32(ImPlot::GetColormapColor(i)), + ImGui::GetColorU32(ImPlot::GetColormapColor(static_cast(i))), row_hovered ? 0.75f : 1.0f)); break; } @@ -708,7 +708,7 @@ Roofline::RenderMenus(const ImVec2 region, const ImGuiStyle& style, ImVec2(icon_width, icon_width) * 0.5f, icon_width * 0.5f - 2 * IMPLOT_LEGEND_ICON_SHRINK, ImGui::GetColorU32( - ImGui::GetColorU32(ImPlot::GetColormapColor(i)), + ImGui::GetColorU32(ImPlot::GetColormapColor(static_cast(i))), row_hovered ? 0.75f : 1.0f), 10); break; diff --git a/src/view/src/compute/rocprofvis_compute_view.cpp b/src/view/src/compute/rocprofvis_compute_view.cpp index 98f2e07e..afc5f43f 100644 --- a/src/view/src/compute/rocprofvis_compute_view.cpp +++ b/src/view/src/compute/rocprofvis_compute_view.cpp @@ -1234,7 +1234,7 @@ ComputeTester::RenderKernelSelectionTable() if(!header.empty() && !data.empty()) { - if(ImGui::BeginTable("kernel_selection_table", header.size(), + if(ImGui::BeginTable("kernel_selection_table", static_cast(header.size()), ImGuiTableFlags_RowBg | ImGuiTableFlags_Borders | ImGuiTableFlags_SizingStretchSame | ImGuiTableFlags_Sortable, ImVec2(0.0f, data.empty() diff --git a/src/view/src/compute/rocprofvis_compute_workload_view.cpp b/src/view/src/compute/rocprofvis_compute_workload_view.cpp index 35400766..7fe06073 100644 --- a/src/view/src/compute/rocprofvis_compute_workload_view.cpp +++ b/src/view/src/compute/rocprofvis_compute_workload_view.cpp @@ -123,7 +123,7 @@ ComputeWorkloadView::RenderSystemInfo(const WorkloadInfo& workload_info) { for(size_t i = 0; i < workload_info.system_info[0].size(); i++) { - ImGui::PushID(i); + ImGui::PushID(static_cast(i)); ImGui::TableNextRow(); ImGui::TableNextColumn(); CopyableTextUnformatted(workload_info.system_info[0][i].c_str(), "", @@ -167,7 +167,7 @@ ComputeWorkloadView::RenderProfilingConfig(const WorkloadInfo& workload_info) { for(size_t i = 0; i < workload_info.profiling_config[0].size(); i++) { - ImGui::PushID(i); + ImGui::PushID(static_cast(i)); ImGui::TableNextRow(); ImGui::TableNextColumn(); CopyableTextUnformatted(workload_info.profiling_config[0][i].c_str(), diff --git a/src/view/src/rocprofvis_annotation_view.cpp b/src/view/src/rocprofvis_annotation_view.cpp index bc83e03d..d15d84f4 100644 --- a/src/view/src/rocprofvis_annotation_view.cpp +++ b/src/view/src/rocprofvis_annotation_view.cpp @@ -41,6 +41,7 @@ AnnotationView::Render() double trace_start_time = m_data_provider.DataModel().GetTimeline().GetStartTime(); + (void)trace_start_time; const auto& time_format = SettingsManager::GetInstance().GetUserSettings().unit_settings.time_format; std::string time_label; diff --git a/src/view/src/rocprofvis_minimap.cpp b/src/view/src/rocprofvis_minimap.cpp index 2037766c..b47566ef 100644 --- a/src/view/src/rocprofvis_minimap.cpp +++ b/src/view/src/rocprofvis_minimap.cpp @@ -121,6 +121,7 @@ Minimap::SetData(const std::vector>& data) } const size_t height = data.size(); + (void)height; const size_t width = data.front().size(); for(const auto& row : data) { @@ -379,8 +380,8 @@ Minimap::RenderViewport(ImDrawList* drawlist, ImVec2 map_pos, ImVec2 map_size) double start_time = m_data_provider.DataModel().GetTimeline().GetStartTime(); double duration = m_data_provider.DataModel().GetTimeline().GetEndTime() - start_time; - float start_ratio = (view_coords.v_min_x - start_time) / duration; - float end_ratio = (view_coords.v_max_x - start_time) / duration; + float start_ratio = static_cast((view_coords.v_min_x - start_time) / duration); + float end_ratio = static_cast((view_coords.v_max_x - start_time) / duration); float x_start = map_pos.x + std::clamp(start_ratio, 0.0f, 1.0f) * map_size.x; float x_end = map_pos.x + std::clamp(end_ratio, 0.0f, 1.0f) * map_size.x; diff --git a/src/view/src/rocprofvis_project.cpp b/src/view/src/rocprofvis_project.cpp index 00d6367f..571d9a97 100644 --- a/src/view/src/rocprofvis_project.cpp +++ b/src/view/src/rocprofvis_project.cpp @@ -178,9 +178,9 @@ Project::OpenTrace(std::string& file_path) { rocprofvis_controller_object_type_t type = kRPVControllerObjectTypeControllerSystem; - rocprofvis_result_t result = + rocprofvis_result_t ctrl_result = rocprofvis_controller_get_object_type(controller, &type); - if(result == kRocProfVisResultSuccess) + if(ctrl_result == kRocProfVisResultSuccess) { if(type == kRPVControllerObjectTypeControllerSystem) { diff --git a/src/view/src/rocprofvis_settings_manager.cpp b/src/view/src/rocprofvis_settings_manager.cpp index aba4e599..f82b3370 100644 --- a/src/view/src/rocprofvis_settings_manager.cpp +++ b/src/view/src/rocprofvis_settings_manager.cpp @@ -527,9 +527,9 @@ SettingsManager::InitStyling() colormap.push_back(255 << IM_COL32_A_SHIFT | flame_color); } colormap.push_back(IM_COL32(220, 50, 50, 255)); - ImPlot::AddColormap("flame", colormap.data(), colormap.size()); + ImPlot::AddColormap("flame", colormap.data(), static_cast(colormap.size())); colormap = { IM_COL32(255, 255, 255, 255), IM_COL32(255, 255, 255, 255) }; - ImPlot::AddColormap("white", colormap.data(), colormap.size()); + ImPlot::AddColormap("white", colormap.data(), static_cast(colormap.size())); } const ImGuiStyle& diff --git a/src/view/src/rocprofvis_stickynote.cpp b/src/view/src/rocprofvis_stickynote.cpp index 0aa55595..dbae36fe 100644 --- a/src/view/src/rocprofvis_stickynote.cpp +++ b/src/view/src/rocprofvis_stickynote.cpp @@ -106,6 +106,7 @@ void StickyNote::Render(ImDrawList* draw_list, const ImVec2& window_position, std::shared_ptr tpt) { + (void)draw_list; if(!tpt) { spdlog::error( diff --git a/src/view/src/rocprofvis_summary_view.cpp b/src/view/src/rocprofvis_summary_view.cpp index 04025f27..b5e37068 100644 --- a/src/view/src/rocprofvis_summary_view.cpp +++ b/src/view/src/rocprofvis_summary_view.cpp @@ -660,7 +660,7 @@ TopKernels::RenderPieChart(const ImVec2 region, const ImPlotStyle& plot_style, hovered_idx = PlotHoverIdx(); ImPlot::PlotPieChart( m_kernel_pie.labels.data(), m_kernel_pie.exec_time_pct.data(), - m_kernel_pie.exec_time_pct.size(), 0.0, 0.0, PIE_CHART_RADIUS, + static_cast(m_kernel_pie.exec_time_pct.size()), 0.0, 0.0, PIE_CHART_RADIUS, [](double value, char* buff, int size, void* user_data) -> int { (void) user_data; if(value * 100.0 > 10.0) @@ -749,9 +749,9 @@ TopKernels::RenderBarChart(const ImVec2 region, const ImPlotStyle& plot_style, { ImPlot::PushColormap("white"); } - ImPlot::SetNextFillStyle(ImPlot::GetColormapColor(i)); + ImPlot::SetNextFillStyle(ImPlot::GetColormapColor(static_cast(i))); ImPlot::PlotBars((*m_kernels)[i].name.c_str(), &(*m_kernels)[i].exec_time_sum, - 1, BAR_CHART_THICKNESS, i); + 1, BAR_CHART_THICKNESS, static_cast(i)); if(i == m_hovered_idx) { ImPlot::PopColormap(); @@ -873,7 +873,8 @@ TopKernels::RenderLegend(const ImVec2 region, const ImGuiStyle& style, for(size_t i = 0; i < m_kernels->size(); i++) { float text_width = ImGui::CalcTextSize((*m_kernels)[i].name.c_str()).x; - ImGui::PushID(i); + (void)text_width; + ImGui::PushID(static_cast(i)); ImVec2 pos = ImGui::GetCursorPos(); bool row_clicked = ImGui::Selectable("", m_selected_idx == i, @@ -887,7 +888,7 @@ TopKernels::RenderLegend(const ImVec2 region, const ImGuiStyle& style, ImGui::GetCursorScreenPos() + ImVec2(icon_width - 2 * IMPLOT_LEGEND_ICON_SHRINK, icon_width - 2 * IMPLOT_LEGEND_ICON_SHRINK), - ImGui::GetColorU32(ImGui::GetColorU32(ImPlot::GetColormapColor(i)), + ImGui::GetColorU32(ImGui::GetColorU32(ImPlot::GetColormapColor(static_cast(i))), row_hovered ? 0.75f : 1.0f)); ImGui::BeginDisabled(i == m_padded_idx); ImGui::SameLine(icon_width); @@ -896,7 +897,7 @@ TopKernels::RenderLegend(const ImVec2 region, const ImGuiStyle& style, ImGui::EndDisabled(); if(row_hovered) { - hovered_idx = i; + hovered_idx = static_cast(i); if(row_clicked && m_selection_callback) { ToggleSelectKernel(i); @@ -934,7 +935,7 @@ TopKernels::PlotHoverIdx() const angle < m_kernel_pie.slices[i].angle + m_kernel_pie.slices[i].size_angle) { - idx = i; + idx = static_cast(i); break; } } @@ -949,7 +950,7 @@ TopKernels::PlotHoverIdx() const mouse_pos.x <= static_cast(i) + PIE_CHART_RADIUS / 2.0 && mouse_pos.y >= 0.0 && mouse_pos.y <= (*m_kernels)[i].exec_time_sum) { - idx = i; + idx = static_cast(i); break; } } diff --git a/src/view/src/rocprofvis_timeline_arrow.cpp b/src/view/src/rocprofvis_timeline_arrow.cpp index 57c35bab..1ced0268 100644 --- a/src/view/src/rocprofvis_timeline_arrow.cpp +++ b/src/view/src/rocprofvis_timeline_arrow.cpp @@ -87,7 +87,7 @@ TimelineArrow::Render(ImDrawList* draw_list, const ImVec2 window, level_height = settings.GetEventLevelHeight(); } - float origin_x = tpt->RawTimeToPixel(origin.end_timestamp); + float origin_x = tpt->RawTimeToPixel(static_cast(origin.end_timestamp)); float origin_y = track_position_y.at(origin.track_id) + std::min(level_height * origin.level + level_height / 2, origin_track.chart->GetTrackHeight()); @@ -111,7 +111,7 @@ TimelineArrow::Render(ImDrawList* draw_list, const ImVec2 window, level_height = settings.GetEventLevelHeight(); } - float target_x = tpt->RawTimeToPixel(target.start_timestamp); + float target_x = tpt->RawTimeToPixel(static_cast(target.start_timestamp)); float target_y = track_position_y.at(target.track_id) + std::min(level_height * target.level + level_height / 2, target_track.chart->GetTrackHeight()); @@ -185,7 +185,7 @@ TimelineArrow::Render(ImDrawList* draw_list, const ImVec2 window, level_height = settings.GetEventLevelHeight(); } - float from_x = tpt->RawTimeToPixel(from.end_timestamp); + float from_x = tpt->RawTimeToPixel(static_cast(from.end_timestamp)); float from_y = track_position_y.at(from.track_id) + std::min(level_height * from.level + level_height / 2, from_track.chart->GetTrackHeight()); @@ -200,7 +200,7 @@ TimelineArrow::Render(ImDrawList* draw_list, const ImVec2 window, level_height = settings.GetEventLevelHeight(); } - float to_x = tpt->RawTimeToPixel(to.start_timestamp); + float to_x = tpt->RawTimeToPixel(static_cast(to.start_timestamp)); float to_y = track_position_y.at(to.track_id) + std::min(level_height * to.level + level_height / 2, to_track.chart->GetTrackHeight()); @@ -255,7 +255,7 @@ TimelineArrow::TimelineArrow(DataProvider& data_provider, std::shared_ptr selection) : m_data_provider(data_provider) , m_timeline_selection(selection) -, m_selection_changed_token(-1) +, m_selection_changed_token(static_cast(-1)) , m_flow_display_mode(FlowDisplayMode::kShowAll) , m_render_style(RenderStyle::kFan) { diff --git a/src/view/src/rocprofvis_timeline_view.cpp b/src/view/src/rocprofvis_timeline_view.cpp index 3da7072a..ac03bdee 100644 --- a/src/view/src/rocprofvis_timeline_view.cpp +++ b/src/view/src/rocprofvis_timeline_view.cpp @@ -116,6 +116,7 @@ TimelineView::TimelineView(DataProvider& dp, static_cast(RocEvents::kSetViewRange), set_view_range_handle); auto font_changed_handler = [this](std::shared_ptr e) { + (void)e; m_recalculate_grid_interval = true; m_ruler_height = ImGui::GetTextLineHeightWithSpacing(); CalculateMaxMetaAreaSize(); diff --git a/src/view/src/rocprofvis_track_item.cpp b/src/view/src/rocprofvis_track_item.cpp index fd25d9d4..8c2a6f7b 100644 --- a/src/view/src/rocprofvis_track_item.cpp +++ b/src/view/src/rocprofvis_track_item.cpp @@ -863,6 +863,7 @@ Pill::Pill(const std::string& label, bool shown, bool active) CalculatePillSize(); auto font_changed_handler = [this](std::shared_ptr e) { + (void)e; CalculatePillSize(); }; m_font_changed_token = EventManager::GetInstance()->Subscribe( diff --git a/src/view/src/rocprofvis_track_topology.cpp b/src/view/src/rocprofvis_track_topology.cpp index 654ea57e..3d0d8377 100644 --- a/src/view/src/rocprofvis_track_topology.cpp +++ b/src/view/src/rocprofvis_track_topology.cpp @@ -33,7 +33,7 @@ TrackTopology::TrackTopology(DataProvider& dp) //subscribe to time format changed event auto format_changed_handler = [this](std::shared_ptr e) { - // Reformat time columns + (void)e; FormatCells(); }; diff --git a/src/view/src/widgets/rocprofvis_compute_widget.cpp b/src/view/src/widgets/rocprofvis_compute_widget.cpp index 12f6aad1..1a65f614 100644 --- a/src/view/src/widgets/rocprofvis_compute_widget.cpp +++ b/src/view/src/widgets/rocprofvis_compute_widget.cpp @@ -65,7 +65,7 @@ void ComputeTableLegacy::Render() ImGui::PopStyleVar(); std::vector>& cells = m_model->m_cells; - if (ImGui::BeginTable(m_id.c_str(), cells[0].size(), ImGuiTableFlags_Borders)) + if (ImGui::BeginTable(m_id.c_str(), static_cast(cells[0].size()), ImGuiTableFlags_Borders)) { for (std::string& c : m_model->m_column_names) { @@ -93,7 +93,7 @@ void ComputeTableLegacy::Render() } else if (cell.m_type == kRPVControllerPrimitiveTypeUInt64) { - value = cell.m_num_value.m_uint64; + value = static_cast(cell.m_num_value.m_uint64); } if (value > TABLE_THRESHOLD_HIGH) { @@ -147,6 +147,7 @@ void ComputePlotPieLegacy::Render() std::vector& series_names = m_model->m_y_axis.m_tick_labels; std::vector& x_values = m_model->m_series[0].m_x_values; std::vector& y_values = m_model->m_series[0].m_y_values; + (void)y_values; ImGui::PushID(m_id.c_str()); if (ImPlot::BeginPlot(title, ImVec2(-1, 0), ImPlotFlags_Equal | ImPlotFlags_NoInputs)) { @@ -205,13 +206,13 @@ void ComputePlotBarLegacy::Render() ImPlot::SetupAxis(ImAxis_Y1, y_label, ImPlotAxisFlags_NoInitialFit | ImPlotAxisFlags_Lock | ImPlotAxisFlags_NoSideSwitch | ImPlotAxisFlags_NoHighlight); ImPlot::SetupAxisLimits(ImAxis_X1, x_min, x_max * 1.01f, ImPlotCond_None); ImPlot::SetupAxisLimits(ImAxis_Y1, -PLOT_BAR_SIZE, series_names.size() - 1 + PLOT_BAR_SIZE, ImPlotCond_None); - ImPlot::SetupAxisTicks(ImAxis_Y1, y_values.data(), y_values.size(), series_names.data()); + ImPlot::SetupAxisTicks(ImAxis_Y1, y_values.data(), static_cast(y_values.size()), series_names.data()); ImPlot::PushStyleColor(ImPlotCol_Line, ImGui::GetColorU32(ImGui::GetStyleColorVec4(ImGuiCol_Text))); for (int i = 0; i < x_values.size(); i ++) { double& value = x_values[i]; ImGui::PushID(i); - ImPlot::SetNextFillStyle(ImPlot::SampleColormap(x_max - x_min > 0 ? value / (x_max - x_min) : 0, PLOT_COLOR_MAP)); + ImPlot::SetNextFillStyle(ImPlot::SampleColormap(static_cast(x_max - x_min > 0 ? value / (x_max - x_min) : 0), PLOT_COLOR_MAP)); ImPlot::PlotBars("", &value, 1, PLOT_BAR_SIZE, i, ImPlotBarsFlags_Horizontal); ImGui::PopID(); } @@ -309,12 +310,12 @@ void ComputePlotRooflineLegacy::Render() ImPlot::SetupLegend(ImPlotLocation_East, ImPlotLegendFlags_Outside); for (int i = 0; i < m_ceilings_names.size(); i ++) { - ImPlot::PlotLine(m_ceilings_names[i], m_ceilings_x[i]->data(), m_ceilings_y[i]->data(), m_ceilings_x[i]->size()); + ImPlot::PlotLine(m_ceilings_names[i], m_ceilings_x[i]->data(), m_ceilings_y[i]->data(), static_cast(m_ceilings_x[i]->size())); } for (int i = 0; i < m_ai_names.size(); i ++) { ImGui::PushID(i); - ImPlot::PlotScatter(m_ai_names[i], m_ai_x[i]->data(), m_ai_y[i]->data(), m_ai_x[i]->size()); + ImPlot::PlotScatter(m_ai_names[i], m_ai_x[i]->data(), m_ai_y[i]->data(), static_cast(m_ai_x[i]->size())); ImGui::PopID(); } ImPlot::EndPlot(); diff --git a/src/view/src/widgets/rocprofvis_infinite_scroll_table.cpp b/src/view/src/widgets/rocprofvis_infinite_scroll_table.cpp index c92be922..4bdd3c33 100644 --- a/src/view/src/widgets/rocprofvis_infinite_scroll_table.cpp +++ b/src/view/src/widgets/rocprofvis_infinite_scroll_table.cpp @@ -62,7 +62,7 @@ InfiniteScrollTable::InfiniteScrollTable(DataProvider& dp, TableType table_type, // subscribe to time format changed event auto format_changed_handler = [this](std::shared_ptr e) { - // Reformat time columns + (void)e; this->FormatData(); }; m_format_changed_token = EventManager::GetInstance()->Subscribe( From a23c5110b5860f277ae323835aafc18844b376a3 Mon Sep 17 00:00:00 2001 From: "Wimalasuriyan, Sajeeth" Date: Thu, 26 Feb 2026 09:15:15 -0500 Subject: [PATCH 2/3] Address PR review comments: remove unused variables (height, trace_start_time) and use EventManager::InvalidSubscriptionToken instead of casting -1. --- src/view/src/rocprofvis_annotation_view.cpp | 3 --- src/view/src/rocprofvis_minimap.cpp | 4 +--- src/view/src/rocprofvis_timeline_arrow.cpp | 2 +- thirdparty/imgui | 2 +- thirdparty/implot | 2 +- 5 files changed, 4 insertions(+), 9 deletions(-) diff --git a/src/view/src/rocprofvis_annotation_view.cpp b/src/view/src/rocprofvis_annotation_view.cpp index d15d84f4..25305ed9 100644 --- a/src/view/src/rocprofvis_annotation_view.cpp +++ b/src/view/src/rocprofvis_annotation_view.cpp @@ -39,9 +39,6 @@ AnnotationView::Render() ImGui::TableSetupColumn("Visibility"); ImGui::TableHeadersRow(); - double trace_start_time = - m_data_provider.DataModel().GetTimeline().GetStartTime(); - (void)trace_start_time; const auto& time_format = SettingsManager::GetInstance().GetUserSettings().unit_settings.time_format; std::string time_label; diff --git a/src/view/src/rocprofvis_minimap.cpp b/src/view/src/rocprofvis_minimap.cpp index b47566ef..fe151230 100644 --- a/src/view/src/rocprofvis_minimap.cpp +++ b/src/view/src/rocprofvis_minimap.cpp @@ -120,9 +120,7 @@ Minimap::SetData(const std::vector>& data) return; } - const size_t height = data.size(); - (void)height; - const size_t width = data.front().size(); + const size_t width = data.front().size(); for(const auto& row : data) { if(row.size() != width) diff --git a/src/view/src/rocprofvis_timeline_arrow.cpp b/src/view/src/rocprofvis_timeline_arrow.cpp index 1ced0268..c34bc54d 100644 --- a/src/view/src/rocprofvis_timeline_arrow.cpp +++ b/src/view/src/rocprofvis_timeline_arrow.cpp @@ -255,7 +255,7 @@ TimelineArrow::TimelineArrow(DataProvider& data_provider, std::shared_ptr selection) : m_data_provider(data_provider) , m_timeline_selection(selection) -, m_selection_changed_token(static_cast(-1)) +, m_selection_changed_token(EventManager::InvalidSubscriptionToken) , m_flow_display_mode(FlowDisplayMode::kShowAll) , m_render_style(RenderStyle::kFan) { diff --git a/thirdparty/imgui b/thirdparty/imgui index 5c1d2d1e..2a1b69f0 160000 --- a/thirdparty/imgui +++ b/thirdparty/imgui @@ -1 +1 @@ -Subproject commit 5c1d2d1e4c562a2ed3efbc64476e703a655b45fd +Subproject commit 2a1b69f05748ad909f03acf4533447cac1331611 diff --git a/thirdparty/implot b/thirdparty/implot index f1b0792c..81b8b195 160000 --- a/thirdparty/implot +++ b/thirdparty/implot @@ -1 +1 @@ -Subproject commit f1b0792cd3e239f615d4f20b9647d37594de8c56 +Subproject commit 81b8b1951392767cf458508385fa025fd087a252 From 0397fbaf438f2d12b8ed467e3ecaa9c2f3155c33 Mon Sep 17 00:00:00 2001 From: "Wimalasuriyan, Sajeeth" Date: Thu, 26 Feb 2026 10:34:40 -0500 Subject: [PATCH 3/3] Fixed imgui verisoning issue caused by upgrade. --- thirdparty/imgui | 2 +- thirdparty/implot | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/thirdparty/imgui b/thirdparty/imgui index 2a1b69f0..5c1d2d1e 160000 --- a/thirdparty/imgui +++ b/thirdparty/imgui @@ -1 +1 @@ -Subproject commit 2a1b69f05748ad909f03acf4533447cac1331611 +Subproject commit 5c1d2d1e4c562a2ed3efbc64476e703a655b45fd diff --git a/thirdparty/implot b/thirdparty/implot index 81b8b195..f1b0792c 160000 --- a/thirdparty/implot +++ b/thirdparty/implot @@ -1 +1 @@ -Subproject commit 81b8b1951392767cf458508385fa025fd087a252 +Subproject commit f1b0792cd3e239f615d4f20b9647d37594de8c56