Skip to content

Commit 60aeed3

Browse files
committed
Remove -Wextra and made test discovery easier
1 parent a33cad1 commit 60aeed3

File tree

2 files changed

+12
-66
lines changed

2 files changed

+12
-66
lines changed

CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ set(CMAKE_SKIP_INSTALL_RPATH FALSE)
4343
# Compiler flags - defined as lists for cleaner management
4444
set(WARNING_FLAGS
4545
"-Wall"
46-
"-Wextra"
4746
"-Winit-self"
4847
"-Wno-switch-bool"
4948
"-Wunused-function"

libflashinfer/tests/CMakeLists.txt

Lines changed: 12 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -4,76 +4,23 @@ set(ALL_TEST_TARGETS "")
44
# Include centralized config utilities
55
include(ConfigureTargets)
66

7-
# Include GoogleTest to enable test discovery
8-
include(GoogleTest)
97
find_package(Threads REQUIRED)
108

119
# cmake-format: off
1210
# === HIP C++ Unit Tests Configuration ===
1311
if(FLASHINFER_ENABLE_HIP)
14-
15-
configure_flashinfer_target(
16-
TARGET_NAME test_batch_decode_hip
17-
SOURCES "hip/test_batch_decode.cpp"
18-
IS_GTEST ON
19-
IS_HIP ON
20-
)
21-
22-
configure_flashinfer_target(
23-
TARGET_NAME test_cascade_hip
24-
SOURCES "hip/test_cascade.cpp"
25-
IS_GTEST ON
26-
IS_HIP ON
27-
)
28-
29-
configure_flashinfer_target(
30-
TARGET_NAME test_layout_transform_hip
31-
SOURCES "hip/test_layout_transform.cpp"
32-
IS_GTEST ON
33-
IS_HIP ON
34-
)
35-
36-
configure_flashinfer_target(
37-
TARGET_NAME test_math_hip
38-
SOURCES "hip/test_math.cpp"
39-
IS_GTEST ON
40-
IS_HIP ON
41-
)
42-
43-
configure_flashinfer_target(
44-
TARGET_NAME test_mfma_fp32_16x16x16fp16_hip
45-
SOURCES "hip/test_mfma_fp32_16x16x16fp16.cpp"
46-
IS_GTEST ON
47-
IS_HIP ON
48-
)
49-
50-
configure_flashinfer_target(
51-
TARGET_NAME test_permuted_smem_hip
52-
SOURCES "hip/test_permuted_smem.cpp"
53-
IS_GTEST ON
54-
IS_HIP ON
55-
)
56-
57-
configure_flashinfer_target(
58-
TARGET_NAME test_pos_enc_hip
59-
SOURCES "hip/test_pos_enc.cpp"
60-
IS_GTEST ON
61-
IS_HIP ON
62-
)
63-
64-
configure_flashinfer_target(
65-
TARGET_NAME test_rowsum_hip
66-
SOURCES "hip/test_rowsum.cpp"
67-
IS_GTEST ON
68-
IS_HIP ON
69-
)
70-
71-
configure_flashinfer_target(
72-
TARGET_NAME test_single_decode_hip
73-
SOURCES "hip/test_single_decode.cpp"
74-
IS_GTEST ON
75-
IS_HIP ON
76-
)
12+
file(GLOB HIP_TEST_SOURCES "${CMAKE_CURRENT_SOURCE_DIR}/hip/*.cpp")
13+
14+
foreach(test_source IN LISTS HIP_TEST_SOURCES)
15+
get_filename_component(test_name ${test_source} NAME_WE)
16+
set(target_name "${test_name}_hip")
17+
configure_flashinfer_target(
18+
TARGET_NAME ${target_name}
19+
SOURCES ${test_source}
20+
IS_GTEST ON
21+
IS_HIP ON
22+
)
23+
endforeach()
7724

7825
endif(FLASHINFER_ENABLE_HIP)
7926
# cmake-format: on

0 commit comments

Comments
 (0)