Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Parser for Attention Contrib OP #3790

Open
3 tasks
TedThemistokleous opened this issue Jan 31, 2025 · 0 comments · May be fixed by #3816
Open
3 tasks

Add Parser for Attention Contrib OP #3790

TedThemistokleous opened this issue Jan 31, 2025 · 0 comments · May be fixed by #3816
Assignees
@TedThemistokleous
Labels
enhancement New feature or request Onnx Operators Adding or modifying an Onnx Operator in the MIGraphX codebase onnxruntime PR changes interaction between MIGraphX and Onnxruntime Perf Improve

Comments

@TedThemistokleous
Copy link
Collaborator

TedThemistokleous commented Jan 31, 2025 •
edited
Loading

Need support for the Onnxruntime Attention Contrib op
https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#com.microsoft.Attention

Onnxruntime optimizations will fuse operators into Attention to speed up inference runs

This consists of the following changes.

  • Add Attention parser for the contrib operator
  • Add tests for varying inputs and parameters
  • Update MIGraphx EP support list in Onnxruntime (migraphx_execution_provider.cc)

We can leverage the existing torch-migraphx converts work via: https://github.com/ROCm/torch_migraphx/blob/de30914d9ddc8e27ca71d93c45688e2f9ca38912/py/torch_migraphx/fx/converters/acc_ops_converters.py#L2534
@TedThemistokleous TedThemistokleous self-assigned this Jan 31, 2025
@TedThemistokleous TedThemistokleous added enhancement New feature or request onnxruntime PR changes interaction between MIGraphX and Onnxruntime Onnx Operators Adding or modifying an Onnx Operator in the MIGraphX codebase Perf Improve labels Jan 31, 2025
@TedThemistokleous TedThemistokleous linked a pull request Feb 20, 2025 that will close this issue
Add Attention Microsoft Contrib Operator #3816
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TedThemistokleous TedThemistokleous

Labels
enhancement New feature or request Onnx Operators Adding or modifying an Onnx Operator in the MIGraphX codebase onnxruntime PR changes interaction between MIGraphX and Onnxruntime Perf Improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Attention Microsoft Contrib Operator ROCm/AMDMIGraphX
1 participant
@TedThemistokleous