Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: QwikDev/qwik
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a05caa8d038b083e5cc23151c300451d166900e5
Choose a base ref
..
head repository: QwikDev/qwik
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 447a3e7ce90b00601213c3e6cf2546a9b69690b1
Choose a head ref
Showing with 9 additions and 9 deletions.
  1. +2 −2 .changeset/thirty-spies-hug.md
  2. +2 −2 packages/docs/src/routes/docs/integrations/authjs/index.mdx
  3. +5 −5 starters/e2e/e2e.render.spec.ts
4 changes: 2 additions & 2 deletions .changeset/thirty-spies-hug.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
'@builder.io/qwik': patch
'@builder.io/qwik': minor
---

FIX: click-to-component works again, and path handling inside the optimizer is simplified
FIX: click-to-component works again, and path handling inside the optimizer is simplified. Note: This changes the QRL hashes due to a different internal path
4 changes: 2 additions & 2 deletions packages/docs/src/routes/docs/integrations/authjs/index.mdx
Original file line number Diff line number Diff line change
@@ -281,8 +281,8 @@ export const { onRequest, useSession, useSignIn, useSignOut } = QwikAuth$(
3. Create or edit the `.env.local` file at the root of your project to store secrets

```bash title=".env.local"
GITHUB_ID=
GITHUB_SECRET=
AUTH_GITHUB_ID=
AUTH_GITHUB_SECRET=
AUTH_SECRET=
```

10 changes: 5 additions & 5 deletions starters/e2e/e2e.render.spec.ts
Original file line number Diff line number Diff line change
@@ -28,31 +28,31 @@ test.describe("render", () => {

const attributes = page.locator("#attributes");

await expect(attributes).toHaveClass("⭐️unvb18-1 even stable0");
await expect(attributes).toHaveClass("⭐️ju3o0m-1 even stable0");
await expect(attributes).toHaveAttribute("aria-hidden", "true");
await expect(attributes).toHaveAttribute("preventdefault:click", "");

await increment.click();

await expect(attributes).toHaveClass("⭐️unvb18-1 odd stable0");
await expect(attributes).toHaveClass("⭐️ju3o0m-1 odd stable0");
await expect(attributes).toHaveAttribute("aria-hidden", "true");
await expect(attributes).toHaveAttribute("preventdefault:click", "");

await toggle.click();

await expect(attributes).toHaveClass("⭐️unvb18-1");
await expect(attributes).toHaveClass("⭐️ju3o0m-1");
await expect(attributes).not.hasAttribute("aria-hidden");
await expect(attributes).not.hasAttribute("preventdefault:click");

await increment.click();

await expect(attributes).toHaveClass("⭐️unvb18-1");
await expect(attributes).toHaveClass("⭐️ju3o0m-1");
await expect(attributes).not.hasAttribute("aria-hidden");
await expect(attributes).not.hasAttribute("preventdefault:click");

await toggle.click();

await expect(attributes).toHaveClass("⭐️unvb18-1 even stable0");
await expect(attributes).toHaveClass("⭐️ju3o0m-1 even stable0");
await expect(attributes).toHaveAttribute("aria-hidden", "true");
await expect(attributes).toHaveAttribute("preventdefault:click", "");
});