Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigator count doesn't update properly when reloading mappings #256

Open
PiTheGuy opened this issue Feb 14, 2025 · 3 comments
Open

Navigator count doesn't update properly when reloading mappings #256

PiTheGuy opened this issue Feb 14, 2025 · 3 comments
Assignees
Labels
bug Something isn't working user interface affects the enigma ui

Comments

@PiTheGuy
Copy link
Contributor

After doing File > Reload Mappings, The count in the navigator in the upper right doesn't update properly. For classes that were open at the time of reload, when the count updates, it counts all tokens, not just those that match the selected filter.

@ix0rai ix0rai added bug Something isn't working user interface affects the enigma ui labels Feb 14, 2025
@ix0rai ix0rai self-assigned this Feb 14, 2025
@ix0rai
Copy link
Member

ix0rai commented Feb 14, 2025

that's so weird. will get this fixed asap!

@ix0rai
Copy link
Member

ix0rai commented Feb 18, 2025

i can't reproduce this in enigma's test project. what are the details of your setup?

@PiTheGuy
Copy link
Contributor Author

PiTheGuy commented Mar 8, 2025

I'm using the Minecraft jar with Parchment mappings.

After a bit of debugging, this appears to be a race condition where entries are added to the navigator before the project's remapper has had it's mappings tree populated. When it then tries to look up the token type, the mapping then isn't found in the tree (because it hasn't been populated yet) and so it defaults to TokenType.OBFUSCATED. This results in every mapping being considered obfuscated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user interface affects the enigma ui
Projects
None yet
Development

No branches or pull requests

2 participants