[BUG] Plugin load problems #2207
Description
Description
The primary problem that I encounter on all servers is extremely slow library initialisation. For example:
[21:22:12 INFO]: [QuickShop-Hikari/Bootstrap] Initializing libraries...
[21:23:00 INFO]: [QuickShop-Hikari] Maven repository mirror test result:
[21:23:00 INFO]: [QuickShop-Hikari] [CN] HUAWEI: 1620ms
[21:23:00 INFO]: [QuickShop-Hikari] [US] CENTRAL: 6611ms
[21:23:00 INFO]: [QuickShop-Hikari] [US] APACHE: 47270ms
[21:23:00 INFO]: [QuickShop-Hikari] [CN] TENCENT: 47598ms
[21:23:00 INFO]: [QuickShop-Hikari] [CN] ALIYUN: 48273ms
[21:23:00 INFO]: [QuickShop-Hikari/Bootstrap] Loading 12 libraries (0 skipped libraries)...
It seems it took nearly a minute to begin initialising the libraries. It appears that you are testing for the lowest latency without any timeout limits on the main thread. Usually it’s not this slow, e.g. 20–30 seconds, but that’s very slow already and just that alone accounts for 70% of the time it takes the server to start. If relevant, my location is Europe.
Also, this Maven test is performed even when all libraries should already be present, i.e. without changing the plugin version, configuration, or in fact anything on the server at all—just a regular reboot.
Have you perhaps considered using Spigot’s library loader? It seems to be significantly faster, and many of your dependencies would already be available from other plugins.
Next, during initialisation, this error always appears:
[21:23:00 INFO]: [QuickShop-Hikari/Bootstrap] Loading library org.apache.commons:commons-lang3:3.14.0 [1/12]
[21:23:00 ERROR]: [STDERR] [org.slf4j.helpers.Util] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
[21:23:00 ERROR]: [STDERR] [org.slf4j.helpers.Util] SLF4J: Defaulting to no-operation (NOP) logger implementation
[21:23:00 ERROR]: [STDERR] [org.slf4j.helpers.Util] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
The plugin works correctly despite this error. The error is always present, and I’ve always seen it since I started using this plugin over a year ago.
I can reproduce the abovementioned issues on Paper 1.20.4 and 1.21.11. Versions in this specific case were Paper 1.21.11 and QS 6.2.0.10.
Steps to reproduce
- Install QuickShop Hikari
- Start the server
Expected Behaviour
QuickShop should not impact server start times this much, and it should not consistently report errors that are beyond my control and not a result of a mistake on my end.
Screenshots
No response
/quickshop paste URL
Irrelevant since this issue is during bootstrapping and consistently reproducible
Additional Context
No response
Checklist
- I'm running Paper, and not a fork
- I confirm that Paper has been updated to the latest build
- I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)
- I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.
- I confirm that I am running a server that is not a Hybrid Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a NeoForge/Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.
- I confirm that I have not read these checkboxes and therefore I just ticked them all.
- I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.