[FRT-54] AI 채팅 - 로딩 애니메이션 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
AI 출력중과 동일하게 로딩 중 입력창을 비활성화하는 방식으로 수정해보았습니다. 확인 부탁드립니다. |
nahyeongjin1
reviewed
Aug 3, 2025
Comment on lines
+103
to
+104
| isLoading={isLoading || showTyping} | ||
| disabled={isLoading || showTyping} |
Member
There was a problem hiding this comment.
isLoading과 disabled 를 둘 다 넘겨주는 이유가 있을까요?
chat-input에서 isLoading은 사용되지 않게 변경되고,
disabled가 기존 isLoading의 역할을 대체하는 식으로 작성되어 있어서
둘 중 하나를 삭제하고 props도 변경하는 것이 어떨까요?
추후 애니메이션 사용에 대한 확장성을 위한 것이라면
chat-input 파일에서 이에 대한 주석을 작성해두는 것도 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Task 🔖
작업 내용 📌
변경 사항 🖥️
테스트 방법 🧑🏻🔬
npm run dev로 실행하여 확인참고 사항 📂
setTimeout제거,isLoading상태 기반으로 애니메이션 제어 필요