Skip to content

Commit 001d101

Browse files
AmirMohammad CheraghaliAmirMohammad Cheraghali
authored andcommitted
Revert "Implement gap-free advanced cartoon with distinct arrows and helices"
This reverts commit 9f93e5c.
1 parent 9f93e5c commit 001d101

1 file changed

Lines changed: 3 additions & 27 deletions

File tree

src/components/ProteinViewer.tsx

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1811,36 +1811,12 @@ export const ProteinViewer = forwardRef<ProteinViewerRef, ProteinViewerProps>(({
18111811
});
18121812
} catch (e) { }
18131813

1814-
18151814
// Unified cartoon with optimized parameters for arrows and helices
1816-
// We split into 3 parts to get distinct styles, using a "not" catch-all to prevent gaps
1817-
1818-
// 1. Helices: Spiral Cylinders
1819-
component.addRepresentation('cartoon', {
1820-
sele: 'helix',
1821-
color: currentColoring,
1822-
radius: 0.25, // Thicker
1823-
subdiv: 15, // Smooth
1824-
radialSegments: 20, // Smooth cylinders
1825-
aspectRatio: 1.0, // Cylindrical (1:1)
1826-
});
1827-
1828-
// 2. Beta Sheets: Flat Arrows
1829-
component.addRepresentation('cartoon', {
1830-
sele: 'sheet',
1831-
color: currentColoring,
1832-
aspectRatio: 10.0, // Very flat/wide arrows
1833-
subdiv: 15, // Smooth
1834-
arrowSegments: 15, // Detailed arrowheads
1835-
});
1836-
1837-
// 3. Loops/Other: Thin Tubes (Catch-all to prevent gaps)
18381815
component.addRepresentation('cartoon', {
1839-
sele: 'not (helix or sheet)', // Mathematically complete coverage
18401816
color: currentColoring,
1841-
aspectRatio: 1.0, // Round/Tubular
1842-
radius: 0.15, // Thinner than helices
1843-
subdiv: 15, // Smooth
1817+
aspectRatio: 5, // Flat arrows for sheets
1818+
subdiv: 12, // Smooth curves
1819+
radialSegments: 20, // Smooth helix cylinders
18441820
});
18451821
} else {
18461822
// Non-cartoon representations

0 commit comments

Comments
 (0)