Skip to content

Commit 065e069

Browse files
committed
Update antihermiticity check
1 parent a030b8b commit 065e069

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

ext/MatrixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ MatrixAlgebraKit.isantihermitian_exact(A::Diagonal{T, <:StridedROCVector{T}}) wh
143143
MatrixAlgebraKit.isantihermitian_approx(A::StridedROCMatrix; kwargs...) =
144144
@invoke MatrixAlgebraKit.isantihermitian_approx(A::Any; kwargs...)
145145
function MatrixAlgebraKit.isantihermitian_approx(A::Diagonal{T, <:StridedROCVector{T}}; atol, rtol, kwargs...) where {T <: Real}
146-
return sum(abs2, A.diag) max(atol, rtol * norm(A))
146+
return norm(A) atol
147147
end
148148

149149
function MatrixAlgebraKit._avgdiff!(A::StridedROCMatrix, B::StridedROCMatrix)

ext/MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ MatrixAlgebraKit.isantihermitian_exact(A::Diagonal{T, <:StridedCuVector{T}}) whe
168168
MatrixAlgebraKit.isantihermitian_approx(A::StridedCuMatrix; kwargs...) =
169169
@invoke MatrixAlgebraKit.isantihermitian_approx(A::Any; kwargs...)
170170
function MatrixAlgebraKit.isantihermitian_approx(A::Diagonal{T, <:StridedCuVector{T}}; atol, rtol, kwargs...) where {T <: Real}
171-
return sum(abs2, A.diag) max(atol, rtol * norm(A))
171+
return norm(A) atol
172172
end
173173

174174
function MatrixAlgebraKit._avgdiff!(A::StridedCuMatrix, B::StridedCuMatrix)

0 commit comments

Comments
 (0)