merge issues, add supportsDelete

Author: qqmyers

src/main/java/edu/harvard/iq/dataverse/engine/command/impl/AbstractSubmitToArchiveCommand.java

@@ -18,6 +18,8 @@
 import edu.harvard.iq.dataverse.util.bagit.BagGenerator;
 import edu.harvard.iq.dataverse.util.bagit.OREMap;
 import edu.harvard.iq.dataverse.workflow.step.WorkflowStepResult;
+import jakarta.ejb.TransactionAttribute;
+import jakarta.ejb.TransactionAttributeType;
 
 import java.io.IOException;
 import java.io.PipedInputStream;
@@ -43,6 +45,7 @@ public AbstractSubmitToArchiveCommand(DataverseRequest aRequest, DatasetVersion
     }
 
     @Override
+    @TransactionAttribute(TransactionAttributeType.NOT_SUPPORTED)
     public DatasetVersion execute(CommandContext ctxt) throws CommandException {
 
         String settings = ctxt.settings().getValueForKey(SettingsServiceBean.Key.ArchiverSettings);
@@ -111,8 +114,8 @@ public Thread startBagThread(DatasetVersion dv, PipedInputStream in, DigestInput
             public void run() {
                 try (PipedOutputStream out = new PipedOutputStream(in)) {
                     // Generate bag
+                    BagGenerator.setNumConnections(getNumberOfBagGeneratorThreads());
                     BagGenerator bagger = new BagGenerator(new OREMap(dv, false), dataciteXml);
-                    bagger.setNumConnections(getNumberOfBagGeneratorThreads());
                     bagger.setAuthenticationKey(token.getTokenString());
                     bagger.generateBag(out);
                     success = true;
@@ -184,4 +187,16 @@ public static boolean isSingleVersion(SettingsWrapper settingsWrapper) {
    public static boolean isSingleVersion(SettingsServiceBean settingsService) {
        return false;
   }
+
+  /** Whether the archiver can delete existing archival files (and thus can retry when the existing files are incomplete/obsolete)
+   * A static version supports calls via reflection while the instance method supports inheritance for use on actual command instances (see DatasetPage for both use cases).
+   * @return
+   */
+  public static boolean supportsDelete() {
+      return false;
+  }
+
+  public boolean canDelete() {
+      return supportsDelete();
+  }
 }